From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 3C87F593A
 for <dev@dpdk.org>; Fri, 23 May 2014 14:47:53 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga101.jf.intel.com with ESMTP; 23 May 2014 05:47:44 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.98,893,1392192000"; d="scan'208";a="516609753"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
 by orsmga001.jf.intel.com with ESMTP; 23 May 2014 05:47:42 -0700
Received: from irsmsx106.ger.corp.intel.com (163.33.3.31) by
 IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS)
 id 14.3.123.3; Fri, 23 May 2014 13:47:41 +0100
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.70]) by
 IRSMSX106.ger.corp.intel.com ([169.254.8.28]) with mapi id 14.03.0123.003;
 Fri, 23 May 2014 13:47:39 +0100
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, "Shaw, Jeffrey B"
 <jeffrey.b.shaw@intel.com>, "Richardson, Bruce" <bruce.richardson@intel.com>, 
 "Venkatesan, Venky" <venky.venkatesan@intel.com>, "nhorman@tuxdriver.com"
 <nhorman@tuxdriver.com>, "stephen@networkplumber.org"
 <stephen@networkplumber.org>
Thread-Topic: [PATCH v2 00/17] add TSO support
Thread-Index: AQHPdc8XoWzTaNFHzkqBPEPDa5Op0ptOHANg
Date: Fri, 23 May 2014 12:47:27 +0000
Message-ID: <2601191342CEEE43887BDE71AB9772580EFA84CD@IRSMSX105.ger.corp.intel.com>
References: <1400507789-18453-1-git-send-email-olivier.matz@6wind.com>
 <466924555.DZ26nc55Es@xps13>
In-Reply-To: <466924555.DZ26nc55Es@xps13>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 00/17] add TSO support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 23 May 2014 12:47:53 -0000

Hi Thomas,

I don't see any big changes in the v2 of that patch.
At least both things that I have concerns about, stay unchanged in the v2:
1) merge physaddr and buf_len in a bitfield - I still think we better keep =
physaddr as 64bit field (PATCH 5).
2) fix_tcp_phdr_cksum() is inside ixgbe TX function, while I think it shoul=
d be moved out of it to the upper layer (PATCH 11).
Thanks
Konstantin

-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20
Sent: Thursday, May 22, 2014 4:02 PM
To: Ananyev, Konstantin; Shaw, Jeffrey B; Richardson, Bruce; Venkatesan, Ve=
nky; nhorman@tuxdriver.com; stephen@networkplumber.org
Cc: Olivier Matz; dev@dpdk.org
Subject: Re: [PATCH v2 00/17] add TSO support

There were many comments on the first version of this serie,
and there is no comment on this second version.
So I understand everyone is OK with it and it can be applied in the git tre=
e.

I'll wait 1 day more. Feel free to comment or acknowledge.

--=20
Thomas