From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCHv3 0/5] ACL library
Date: Fri, 13 Jun 2014 12:02:31 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB9772580EFB6982@IRSMSX105.ger.corp.intel.com> (raw)
In-Reply-To: <3012262.OhlkyXXJnt@xps13>
Hi Thomas,
These changes would require a lot of changes inside ACL library.
As I said in cover letter, ACL library was part of IPL code for a while (nearly a year).
I don't really want to make significant changes in it just before the release without really good reason - bugs found.
Thanks
Konstantin
-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
Sent: Friday, June 13, 2014 12:56 PM
To: Ananyev, Konstantin
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCHv3 0/5] ACL library
Hi Konstantin,
> Konstantin Ananyev (5):
> Add ACL library (librte_acl) into DPDK
> acl: update UT to reflect latest changes in the librte_acl
> acl: New test-acl application
> acl: New sample l3fwd-acl
> acl: add doxygen configuration and start page
>
> v2 fixes:
> * Fixed several checkpatch.pl issues
> * Added doxygen related changes
>
> v3 fixes:
> * Fixed even more checkpatch.pl issues
Sorry to bother you but after checking v3,
I think these errors should be avoided:
ERROR: do not use assignment in if condition
ERROR: return is not a function, parentheses are not required
Thanks
--
Thomas
next prev parent reply other threads:[~2014-06-13 12:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 11:26 Konstantin Ananyev
2014-06-13 11:26 ` [dpdk-dev] [PATCHv3 1/5] Add ACL library (librte_acl) into DPDK Konstantin Ananyev
2014-06-13 11:26 ` [dpdk-dev] [PATCHv3 2/5] acl: update UT to reflect latest changes in the librte_acl Konstantin Ananyev
2014-06-13 11:26 ` [dpdk-dev] [PATCHv3 3/5] acl: New test-acl application Konstantin Ananyev
2014-06-13 11:26 ` [dpdk-dev] [PATCHv3 4/5] acl: New sample l3fwd-acl Konstantin Ananyev
2014-06-13 11:26 ` [dpdk-dev] [PATCHv3 5/5] acl: add doxygen configuration and start page Konstantin Ananyev
2014-06-13 11:56 ` [dpdk-dev] [PATCHv3 0/5] ACL library Thomas Monjalon
2014-06-13 12:02 ` Ananyev, Konstantin [this message]
2014-06-13 23:38 ` Thomas Monjalon
2014-06-14 0:07 ` Richardson, Bruce
2014-06-14 7:55 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB9772580EFB6982@IRSMSX105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).