From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 8D52AAFCE for ; Fri, 13 Jun 2014 14:03:13 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 13 Jun 2014 05:03:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,471,1400050800"; d="scan'208";a="555022279" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga002.fm.intel.com with ESMTP; 13 Jun 2014 05:03:17 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.239]) by IRSMSX104.ger.corp.intel.com ([169.254.5.136]) with mapi id 14.03.0123.003; Fri, 13 Jun 2014 13:02:32 +0100 From: "Ananyev, Konstantin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCHv3 0/5] ACL library Thread-Index: AQHPhv6QxeNwmLt1akS6P1X7SBG5v5tu70pw Date: Fri, 13 Jun 2014 12:02:31 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772580EFB6982@IRSMSX105.ger.corp.intel.com> References: <1402658814-21881-1-git-send-email-konstantin.ananyev@intel.com> <3012262.OhlkyXXJnt@xps13> In-Reply-To: <3012262.OhlkyXXJnt@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCHv3 0/5] ACL library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jun 2014 12:03:14 -0000 Hi Thomas, These changes would require a lot of changes inside ACL library. As I said in cover letter, ACL library was part of IPL code for a while (ne= arly a year). I don't really want to make significant changes in it just before the relea= se without really good reason - bugs found. Thanks Konstantin -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20 Sent: Friday, June 13, 2014 12:56 PM To: Ananyev, Konstantin Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCHv3 0/5] ACL library Hi Konstantin, > Konstantin Ananyev (5): > Add ACL library (librte_acl) into DPDK > acl: update UT to reflect latest changes in the librte_acl > acl: New test-acl application > acl: New sample l3fwd-acl > acl: add doxygen configuration and start page >=20 > v2 fixes: > * Fixed several checkpatch.pl issues > * Added doxygen related changes >=20 > v3 fixes: > * Fixed even more checkpatch.pl issues Sorry to bother you but after checking v3, I think these errors should be avoided: ERROR: do not use assignment in if condition ERROR: return is not a function, parentheses are not required Thanks --=20 Thomas