From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by dpdk.org (Postfix) with ESMTP id 2039AB10F for ; Tue, 24 Jun 2014 19:48:42 +0200 (CEST) Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga101.ch.intel.com with ESMTP; 24 Jun 2014 10:48:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,539,1400050800"; d="scan'208";a="449440072" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by azsmga001.ch.intel.com with ESMTP; 24 Jun 2014 10:48:34 -0700 Received: from irsmsx106.ger.corp.intel.com (163.33.3.31) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.123.3; Tue, 24 Jun 2014 18:48:34 +0100 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.76]) by IRSMSX106.ger.corp.intel.com ([169.254.8.192]) with mapi id 14.03.0123.003; Tue, 24 Jun 2014 18:48:33 +0100 From: "Ananyev, Konstantin" To: Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH] mempool: don't leak ring on failure Thread-Index: AQHPj8QYQ7ZoaTliqUCLplGQnzL/EpuAbGIAgAAKOoCAABHEMA== Date: Tue, 24 Jun 2014 17:48:33 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725821334117@IRSMSX105.ger.corp.intel.com> References: <20140624084948.6d4ab3cd@nehalam.linuxnetplumber.net> <2601191342CEEE43887BDE71AB977258213340B1@IRSMSX105.ger.corp.intel.com> <20140624104057.1fa81fd6@nehalam.linuxnetplumber.net> In-Reply-To: <20140624104057.1fa81fd6@nehalam.linuxnetplumber.net> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] mempool: don't leak ring on failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jun 2014 17:48:43 -0000 >=20 > On Tue, 24 Jun 2014 16:16:02 +0000 > "Ananyev, Konstantin" wrote: >=20 > > But now, memzone created for the actual mempool could get leaked instea= d? >=20 > Since memzone's can't be destroyed, then only solution would be if > checked if memzone with same name already exists. Actually, wouldn't it be the better way to create one memzone for both memp= ool and its ring? Now we have rte_ring_init(). Konstantin