From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id DF8DB959
 for <dev@dpdk.org>; Wed, 30 Jul 2014 17:36:26 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga101.fm.intel.com with ESMTP; 30 Jul 2014 08:36:52 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.01,764,1400050800"; d="scan'208";a="569500930"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
 by fmsmga001.fm.intel.com with ESMTP; 30 Jul 2014 08:36:51 -0700
Received: from irsmsx110.ger.corp.intel.com (163.33.3.25) by
 IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS)
 id 14.3.123.3; Wed, 30 Jul 2014 16:36:50 +0100
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.65]) by
 IRSMSX110.ger.corp.intel.com ([163.33.3.25]) with mapi id 14.03.0123.003;
 Wed, 30 Jul 2014 16:36:50 +0100
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Neil Horman <nhorman@tuxdriver.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH v2 0/2] dpdk: Allow for dynamic enablement of some
 isolated features
Thread-Index: AQHPrAWl5l1OJQgoukKB6Oa2PFEqfJu4v5tA
Date: Wed, 30 Jul 2014 15:36:50 +0000
Message-ID: <2601191342CEEE43887BDE71AB9772582134581E@IRSMSX105.ger.corp.intel.com>
References: <1406665466-29654-1-git-send-email-nhorman@tuxdriver.com>
 <1406731769-18523-1-git-send-email-nhorman@tuxdriver.com>
In-Reply-To: <1406731769-18523-1-git-send-email-nhorman@tuxdriver.com>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 0/2] dpdk: Allow for dynamic enablement of
 some isolated features
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Jul 2014 15:36:27 -0000

> -----Original Message-----
> From: Neil Horman [mailto:nhorman@tuxdriver.com]
> Sent: Wednesday, July 30, 2014 3:49 PM
> To: dev@dpdk.org
> Cc: Ananyev, Konstantin; Neil Horman; Thomas Monjalon
> Subject: [PATCH v2 0/2] dpdk: Allow for dynamic enablement of some isolat=
ed features
>=20
> Hey all-
>         I've been trying to update the fedora dpdk package to support VFI=
O
> enabled drivers and ran into a problem in which ixgbe didn't compile beca=
use the
> rxtx_vec code uses sse4.2 instruction intrinsics, which aren't supported =
in the
> default config I have.  I tried to remedy this by replacing the intrinsic=
s with
> the __builtin macros, but it was pointed out (correctly), that this doesn=
't work
> properly.  So this is my second attempt, which I actually like a bit bett=
er.  I
> noted that code that uses intrinsics (ixgbe and the acl library), don't n=
eed to
> have those instructions turned on build-wide.  Rather, we can just enable=
 the
> instructions in the specific code we want to build with support for that,=
 and
> test for instruction support dynamically at run time.  This allows me to =
build
> the dpdk for a generic platform, but in such a way that some optimization=
s can
> be used if the executing cpu supports them at run time.
>=20
> Change notes:
>=20
> v2)
> 	* Added Log messages to run time check failures per Konstantin
> 	* Removed run time check caching in acl per Konstantin
>=20
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> CC: Thomas Monjalon <thomas.monjalon@6wind.com>

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>