From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 127962E8B for ; Wed, 3 Sep 2014 11:39:23 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 03 Sep 2014 02:43:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,456,1406617200"; d="scan'208";a="585543211" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga001.fm.intel.com with ESMTP; 03 Sep 2014 02:43:57 -0700 Received: from irsmsx152.ger.corp.intel.com (163.33.192.66) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 3 Sep 2014 10:43:44 +0100 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.158]) by IRSMSX152.ger.corp.intel.com ([169.254.6.48]) with mapi id 14.03.0195.001; Wed, 3 Sep 2014 10:43:44 +0100 From: "Ananyev, Konstantin" To: Stephen Hemminger , "Xie, Huawei" Thread-Topic: [dpdk-dev] [PATCH 2/3] lib/librte_vhost: vhost library support to facilitate integration with DPDK accelerated vswitch Thread-Index: AQHPxyikCIAElc+oAk2v4Mb7fkbgiZvu08EAgAAGSICAAE3/YA== Date: Wed, 3 Sep 2014 09:43:43 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725821360229@IRSMSX105.ger.corp.intel.com> References: <1409648131-4301-1-git-send-email-huawei.xie@intel.com> <1409648131-4301-3-git-send-email-huawei.xie@intel.com> <54068D47.4090401@igel.co.jp> <20140902230153.0f4f4375@urahara> In-Reply-To: <20140902230153.0f4f4375@urahara> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 2/3] lib/librte_vhost: vhost library support to facilitate integration with DPDK accelerated vswitch X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Sep 2014 09:39:24 -0000 > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Wednesday, September 03, 2014 7:02 AM > To: Xie, Huawei > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/3] lib/librte_vhost: vhost library suppo= rt to facilitate integration with DPDK accelerated vswitch >=20 > On Wed, 3 Sep 2014 05:39:24 +0000 > "Xie, Huawei" wrote: >=20 > > Thanks Tetsuya: > > Some of them are due to 80 character limitation. Is it ok to break the= limitation for better indentation? >=20 > Many of these comments could just be removed or shortened. > Often removing comments makes code clearer and less buggy, because > there is no risk that comment does not match code. If comment string is longer than 80 characters, why just not split comment= string into multiline?=20