From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6CD237E75 for ; Wed, 12 Nov 2014 18:31:05 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 12 Nov 2014 09:27:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,370,1413270000"; d="scan'208";a="630918131" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga002.fm.intel.com with ESMTP; 12 Nov 2014 09:21:25 -0800 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 12 Nov 2014 17:21:19 +0000 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.56]) by IRSMSX155.ger.corp.intel.com ([169.254.14.70]) with mapi id 14.03.0195.001; Wed, 12 Nov 2014 17:21:18 +0000 From: "Ananyev, Konstantin" To: "Richardson, Bruce" , Olivier Matz Thread-Topic: [PATCH 06/12] mbuf: add functions to get the name of an ol_flag Thread-Index: AQHP/QzsWOSJfToMmU+b5jde8ZgFRZxdPmFA Date: Wed, 12 Nov 2014 17:21:17 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213A41C6@IRSMSX105.ger.corp.intel.com> References: <1415635166-1364-1-git-send-email-olivier.matz@6wind.com> <1415635166-1364-7-git-send-email-olivier.matz@6wind.com> <20141110171905.GF10776@bricha3-MOBL3> In-Reply-To: <20141110171905.GF10776@bricha3-MOBL3> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" , "jigsaw@gmail.com" Subject: Re: [dpdk-dev] [PATCH 06/12] mbuf: add functions to get the name of an ol_flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Nov 2014 17:31:06 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Monday, November 10, 2014 5:30 PM > To: Olivier Matz > Cc: dev@dpdk.org; Walukiewicz, Miroslaw; Liu, Jijiang; Liu, Yong; jigsaw@= gmail.com; Ananyev, Konstantin > Subject: Re: [PATCH 06/12] mbuf: add functions to get the name of an ol_f= lag >=20 > On Mon, Nov 10, 2014 at 04:59:20PM +0100, Olivier Matz wrote: > > In test-pmd (rxonly.c), the code is able to dump the list of ol_flags. > > The issue is that the list of flags in the application has to be > > synchronized with the flags defined in rte_mbuf.h. > > > > This patch introduces 2 new functions rte_get_rx_ol_flag_name() > > and rte_get_tx_ol_flag_name() that returns the name of a flag from > > its mask. It also fixes rxonly.c to use this new functions and to > > display the proper flags. >=20 > Good idea. Couple of minor comments below. Yes, that looks like a good idea to me too. Just one thought - there is probably no need to make rte_get_*_ol_flag_name= () inlined and put them into rte_mbuf.h Seems like rte_mbuf.c - is a good place for these 2 functions definitions. Konstantin >=20 > /Bruce >=20 > > > > Signed-off-by: Olivier Matz > > --- > > app/test-pmd/rxonly.c | 36 ++++++++-------------------- > > lib/librte_mbuf/rte_mbuf.h | 60 ++++++++++++++++++++++++++++++++++++++= ++++++++ > > 2 files changed, 70 insertions(+), 26 deletions(-) > > > > diff --git a/app/test-pmd/rxonly.c b/app/test-pmd/rxonly.c > > index 4410c3d..e7cd7e2 100644 > > --- a/app/test-pmd/rxonly.c > > +++ b/app/test-pmd/rxonly.c > > @@ -71,26 +71,6 @@ > > > > #include "testpmd.h" > > > > -#define MAX_PKT_RX_FLAGS 13 > > -static const char *pkt_rx_flag_names[MAX_PKT_RX_FLAGS] =3D { > > - "VLAN_PKT", > > - "RSS_HASH", > > - "PKT_RX_FDIR", > > - "IP_CKSUM", > > - "IP_CKSUM_BAD", > > - > > - "IPV4_HDR", > > - "IPV4_HDR_EXT", > > - "IPV6_HDR", > > - "IPV6_HDR_EXT", > > - > > - "IEEE1588_PTP", > > - "IEEE1588_TMST", > > - > > - "TUNNEL_IPV4_HDR", > > - "TUNNEL_IPV6_HDR", > > -}; > > - > > static inline void > > print_ether_addr(const char *what, struct ether_addr *eth_addr) > > { > > @@ -219,12 +199,16 @@ pkt_burst_receive(struct fwd_stream *fs) > > printf(" - Receive queue=3D0x%x", (unsigned) fs->rx_queue); > > printf("\n"); > > if (ol_flags !=3D 0) { > > - int rxf; > > - > > - for (rxf =3D 0; rxf < MAX_PKT_RX_FLAGS; rxf++) { > > - if (ol_flags & (1 << rxf)) > > - printf(" PKT_RX_%s\n", > > - pkt_rx_flag_names[rxf]); > > + unsigned rxf; > > + const char *name; > > + > > + for (rxf =3D 0; rxf < sizeof(mb->ol_flags) * 8; rxf++) { > > + if ((ol_flags & (1ULL << rxf)) =3D=3D 0) > > + continue; > > + name =3D rte_get_rx_ol_flag_name(1ULL << rxf); > > + if (name =3D=3D NULL) > > + continue; > > + printf(" %s\n", name); > > } > > } > > rte_pktmbuf_free(mb); > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > > index ff11b84..bcd8996 100644 > > --- a/lib/librte_mbuf/rte_mbuf.h > > +++ b/lib/librte_mbuf/rte_mbuf.h > > @@ -129,6 +129,66 @@ extern "C" { > > /* Use final bit of flags to indicate a control mbuf */ > > #define CTRL_MBUF_FLAG (1ULL << 63) /**< Mbuf contains control d= ata */ > > > > +/** > > + * Bit Mask to indicate what bits required for building TX context > I don't understand this first line - is it accidentally included? >=20 > > + * Get the name of a RX offload flag > > + * > > + * @param mask > > + * The mask describing the flag. Usually only one bit must be set. > > + * Several bits can be given if they belong to the same mask. > > + * Ex: PKT_TX_L4_MASK. > TX mask given as an example for a function for RX flags is confusing. >=20 > > + * @return > > + * The name of this flag, or NULL if it's not a valid RX flag. > > + */ > > +static inline const char *rte_get_rx_ol_flag_name(uint64_t mask) > > +{ > > + switch (mask) { > > + case PKT_RX_VLAN_PKT: return "PKT_RX_VLAN_PKT"; > > + case PKT_RX_RSS_HASH: return "PKT_RX_RSS_HASH"; > > + case PKT_RX_FDIR: return "PKT_RX_FDIR"; > > + case PKT_RX_L4_CKSUM_BAD: return "PKT_RX_L4_CKSUM_BAD"; > > + case PKT_RX_IP_CKSUM_BAD: return "PKT_RX_IP_CKSUM_BAD"; > > + /* case PKT_RX_EIP_CKSUM_BAD: return "PKT_RX_EIP_CKSUM_BAD"; */ > > + /* case PKT_RX_OVERSIZE: return "PKT_RX_OVERSIZE"; */ > > + /* case PKT_RX_HBUF_OVERFLOW: return "PKT_RX_HBUF_OVERFLOW"; */ > > + /* case PKT_RX_RECIP_ERR: return "PKT_RX_RECIP_ERR"; */ > > + /* case PKT_RX_MAC_ERR: return "PKT_RX_MAC_ERR"; */ > > + case PKT_RX_IPV4_HDR: return "PKT_RX_IPV4_HDR"; > > + case PKT_RX_IPV4_HDR_EXT: return "PKT_RX_IPV4_HDR_EXT"; > > + case PKT_RX_IPV6_HDR: return "PKT_RX_IPV6_HDR"; > > + case PKT_RX_IPV6_HDR_EXT: return "PKT_RX_IPV6_HDR_EXT"; > > + case PKT_RX_IEEE1588_PTP: return "PKT_RX_IEEE1588_PTP"; > > + case PKT_RX_IEEE1588_TMST: return "PKT_RX_IEEE1588_TMST"; > > + case PKT_RX_TUNNEL_IPV4_HDR: return "PKT_RX_TUNNEL_IPV4_HDR"; > > + case PKT_RX_TUNNEL_IPV6_HDR: return "PKT_RX_TUNNEL_IPV6_HDR"; > > + default: return NULL; > > + } > > +} > > + > > +/** > > + * Get the name of a TX offload flag > > + * > > + * @param mask > > + * The mask describing the flag. Usually only one bit must be set. > > + * Several bits can be given if they belong to the same mask. > > + * Ex: PKT_TX_L4_MASK. > > + * @return > > + * The name of this flag, or NULL if it's not a valid TX flag. > > + */ > > +static inline const char *rte_get_tx_ol_flag_name(uint64_t mask) > > +{ > > + switch (mask) { > > + case PKT_TX_VLAN_PKT: return "PKT_TX_VLAN_PKT"; > > + case PKT_TX_IP_CKSUM: return "PKT_TX_IP_CKSUM"; > > + case PKT_TX_TCP_CKSUM: return "PKT_TX_TCP_CKSUM"; > > + case PKT_TX_SCTP_CKSUM: return "PKT_TX_SCTP_CKSUM"; > > + case PKT_TX_UDP_CKSUM: return "PKT_TX_UDP_CKSUM"; > > + case PKT_TX_IEEE1588_TMST: return "PKT_TX_IEEE1588_TMST"; > > + case PKT_TX_VXLAN_CKSUM: return "PKT_TX_VXLAN_CKSUM"; > > + default: return NULL; > > + } > > +} > > + > > /* define a set of marker types that can be used to refer to set point= s in the > > * mbuf */ > > typedef void *MARKER[0]; /**< generic marker for a point in a str= ucture */ > > -- > > 2.1.0 > >