From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 46D547E70 for ; Tue, 18 Nov 2014 16:15:57 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 18 Nov 2014 07:26:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,410,1413270000"; d="scan'208";a="633912873" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga002.fm.intel.com with ESMTP; 18 Nov 2014 07:26:16 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.144]) by IRSMSX153.ger.corp.intel.com ([163.33.192.75]) with mapi id 14.03.0195.001; Tue, 18 Nov 2014 15:26:04 +0000 From: "Ananyev, Konstantin" To: "Zhang, Helin" , "Liu, Jijiang" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 0/4] Translate packet types for i40e Thread-Index: AQHQAwKdtAq8eAMesEe9YHLlK90XlpxmOTcwgAA0DACAABLUUA== Date: Tue, 18 Nov 2014 15:26:03 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213B58B9@IRSMSX105.ger.corp.intel.com> References: <1416296251-7534-1-git-send-email-jijiang.liu@intel.com> <2601191342CEEE43887BDE71AB977258213B581A@IRSMSX105.ger.corp.intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/4] Translate packet types for i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Nov 2014 15:15:57 -0000 > -----Original Message----- > From: Zhang, Helin > Sent: Tuesday, November 18, 2014 2:12 PM > To: Ananyev, Konstantin; Liu, Jijiang; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 0/4] Translate packet types for i40e >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ananyev, Konstanti= n > > Sent: Tuesday, November 18, 2014 7:33 PM > > To: Liu, Jijiang; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 0/4] Translate packet types for i40e > > > > Hi Frank, > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu > > > Sent: Tuesday, November 18, 2014 7:37 AM > > > To: dev@dpdk.org > > > Subject: [dpdk-dev] [PATCH 0/4] Translate packet types for i40e > > > > > > The i40e NIC can recognize many packet types, including ordinary L2 > > > packet format and tunneling packet format such as IP in IP, IP in GRE= , MAC in > > GRE and MAC in UDP. > > > > > > This patch set provides abstract definitions of packet types, which > > > can help user to use these packet types directly in their application= s to speed > > up receive packet analysis. > > > > > > Moreover, this patch set translates i40e packet types to abstract > > > packet types in i40e driver, and make the corresponding changes in te= st > > applications. > > > > > > Jijiang Liu (4): > > > Add packet type and IP header check in rte_mbuf > > > Remove the PKT_RX_TUNNEL_IPV4_HDR and the > > PKT_RX_TUNNEL_IPV6_HDR > > > Translate i40e packet types > > > Make the corresponding changes in test-pmd > > > > > > app/test-pmd/csumonly.c | 12 +- > > > app/test-pmd/rxonly.c | 15 +- > > > lib/librte_mbuf/rte_mbuf.h | 225 ++++++++++++++- > > > lib/librte_pmd_i40e/i40e_rxtx.c | 604 > > > +++++++++++++++++++++------------------ > > > 4 files changed, 569 insertions(+), 287 deletions(-) > > > > > > > The patch looks good to me in general. > > Though I think it is not complete: we need to make sure that all PMDs R= X > > functions will set mbuf's packet_type to the defined value. > We met quite a lot of similar situations, we designed a new way for i40e,= then > have to rework igb/ixgbe. E.g. configuring reta, flow director, etc. > If possible, send the patch set as smaller as possible might be better. I= guess > igb/ixgbe will be done soon later. >=20 > > As right now, only i40e implementation can distinguish packet_type prop= erly, I > > think all other PMDs for the freshly received packet should do: > > mbuf->packet_type =3D RTE_PTYPE_UNDEF; > If I am not wrong, RTE_PTYPE_UNDEF can be 0, is packet_type in mbuf initi= alized to 0? Yes RTE_PTYPE_UNDEF =3D=3D 0 > If yes, nothing needs to be done in igb/ixgbe for now. Could you explain to me why is that? As I remember none of our RX functions reset the whole mbuf to all zeroes. None of them even call rte_pktmbuf_reset() for performance reasons. So what/who would prevent reset packet_type of the freshly received packet_= type to zero? BTW, I think that rte_pktmbuf_reset() need to reset packet_type too. >=20 > > > > Another thing: right now mbuf's packet_type is uint16_t. > > While enum rte_eth_packet_type will be interpreted by the compiler as '= int' > > (32bits). > > We can either change enum to a lot of defines (which I don't really lik= e to do) or > > probably just add a comment somewhere that enum rte_eth_packet_type > > should never exceed UINT16_MAX value? > > > > Konstantin > > > > > -- > > > 1.7.7.6 >=20 > Regards, > Helin