From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E0B87595B for ; Tue, 18 Nov 2014 16:19:58 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 18 Nov 2014 07:30:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,410,1413270000"; d="scan'208";a="633914418" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga002.fm.intel.com with ESMTP; 18 Nov 2014 07:29:28 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.144]) by IRSMSX106.ger.corp.intel.com ([169.254.8.18]) with mapi id 14.03.0195.001; Tue, 18 Nov 2014 15:29:08 +0000 From: "Ananyev, Konstantin" To: "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH 0/4] Translate packet types for i40e Thread-Index: AQHQAwKdtAq8eAMesEe9YHLlK90XlpxmOTcwgAAiQACAACaRwA== Date: Tue, 18 Nov 2014 15:29:08 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213B58D0@IRSMSX105.ger.corp.intel.com> References: <1416296251-7534-1-git-send-email-jijiang.liu@intel.com> <2601191342CEEE43887BDE71AB977258213B581A@IRSMSX105.ger.corp.intel.com> <20141118130828.GA10768@bricha3-MOBL3> In-Reply-To: <20141118130828.GA10768@bricha3-MOBL3> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 0/4] Translate packet types for i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Nov 2014 15:19:59 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Tuesday, November 18, 2014 1:08 PM > To: Ananyev, Konstantin > Cc: Liu, Jijiang; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/4] Translate packet types for i40e >=20 > On Tue, Nov 18, 2014 at 11:33:24AM +0000, Ananyev, Konstantin wrote: > > Hi Frank, > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu > > > Sent: Tuesday, November 18, 2014 7:37 AM > > > To: dev@dpdk.org > > > Subject: [dpdk-dev] [PATCH 0/4] Translate packet types for i40e > > > > > > The i40e NIC can recognize many packet types, including ordinary L2 p= acket format and tunneling packet format such as IP in IP, IP > in > > > GRE, MAC in GRE and MAC in UDP. > > > > > > This patch set provides abstract definitions of packet types, > > > which can help user to use these packet types directly in their appli= cations to speed up receive packet analysis. > > > > > > Moreover, this patch set translates i40e packet types to abstract pac= ket types in i40e driver, > > > and make the corresponding changes in test applications. > > > > > > Jijiang Liu (4): > > > Add packet type and IP header check in rte_mbuf > > > Remove the PKT_RX_TUNNEL_IPV4_HDR and the PKT_RX_TUNNEL_IPV6_HDR > > > Translate i40e packet types > > > Make the corresponding changes in test-pmd > > > > > > app/test-pmd/csumonly.c | 12 +- > > > app/test-pmd/rxonly.c | 15 +- > > > lib/librte_mbuf/rte_mbuf.h | 225 ++++++++++++++- > > > lib/librte_pmd_i40e/i40e_rxtx.c | 604 +++++++++++++++++++++--------= ---------- > > > 4 files changed, 569 insertions(+), 287 deletions(-) > > > > > > > The patch looks good to me in general. > > Though I think it is not complete: we need to make sure that all PMDs R= X functions will set mbuf's packet_type > > to the defined value. > > As right now, only i40e implementation can distinguish packet_type prop= erly, I think all other PMDs > > for the freshly received packet should do: > > mbuf->packet_type =3D RTE_PTYPE_UNDEF; > > > > Another thing: right now mbuf's packet_type is uint16_t. > > While enum rte_eth_packet_type will be interpreted by the compiler as '= int' (32bits). > > We can either change enum to a lot of defines (which I don't really lik= e to do) or probably just > > add a comment somewhere that enum rte_eth_packet_type should never exc= eed UINT16_MAX value? > > > Add a RTE_PTYPE_MAX value =3D UINT16_MAX to the enum, perhaps? Yep, add something like RTE_PTYPE_MAX =3D UINT16_MAX and RTE_PTYPE_MIN =3D= =3D 0 seems like a good thing to me too. >=20 > /Bruce