From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 61453682E for ; Wed, 19 Nov 2014 11:56:30 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 19 Nov 2014 03:06:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,416,1413270000"; d="scan'208";a="634437731" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga002.fm.intel.com with ESMTP; 19 Nov 2014 03:06:53 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.144]) by IRSMSX153.ger.corp.intel.com ([163.33.192.75]) with mapi id 14.03.0195.001; Wed, 19 Nov 2014 11:06:48 +0000 From: "Ananyev, Konstantin" To: Olivier MATZ , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 06/13] mbuf: add functions to get the name of an ol_flag Thread-Index: AQHQAC0gx1uA8Hd/WEmdIDKnZALmDZxlJ+CAgAD8JQCAAaggIA== Date: Wed, 19 Nov 2014 11:06:47 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213B6BDA@IRSMSX105.ger.corp.intel.com> References: <1415635166-1364-1-git-send-email-olivier.matz@6wind.com> <1415984609-2484-1-git-send-email-olivier.matz@6wind.com> <1415984609-2484-7-git-send-email-olivier.matz@6wind.com> <2601191342CEEE43887BDE71AB977258213AE5A1@IRSMSX105.ger.corp.intel.com> <546B1188.2090203@6wind.com> In-Reply-To: <546B1188.2090203@6wind.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "jigsaw@gmail.com" Subject: Re: [dpdk-dev] [PATCH v2 06/13] mbuf: add functions to get the name of an ol_flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Nov 2014 10:56:31 -0000 > -----Original Message----- > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > Sent: Tuesday, November 18, 2014 9:30 AM > To: Ananyev, Konstantin; dev@dpdk.org > Cc: jigsaw@gmail.com; Zhang, Helin > Subject: Re: [dpdk-dev] [PATCH v2 06/13] mbuf: add functions to get the n= ame of an ol_flag >=20 > Hi Konstantin, >=20 > On 11/17/2014 08:00 PM, Ananyev, Konstantin wrote: > >> +/* > >> + * Get the name of a RX offload flag > >> + */ > >> +const char *rte_get_rx_ol_flag_name(uint64_t mask) > >> +{ > >> + switch (mask) { > >> + case PKT_RX_VLAN_PKT: return "PKT_RX_VLAN_PKT"; > >> + case PKT_RX_RSS_HASH: return "PKT_RX_RSS_HASH"; > >> + case PKT_RX_FDIR: return "PKT_RX_FDIR"; > >> + case PKT_RX_L4_CKSUM_BAD: return "PKT_RX_L4_CKSUM_BAD"; > >> + case PKT_RX_IP_CKSUM_BAD: return "PKT_RX_IP_CKSUM_BAD"; > >> + /* case PKT_RX_EIP_CKSUM_BAD: return "PKT_RX_EIP_CKSUM_BAD"; */ > >> + /* case PKT_RX_OVERSIZE: return "PKT_RX_OVERSIZE"; */ > >> + /* case PKT_RX_HBUF_OVERFLOW: return "PKT_RX_HBUF_OVERFLOW"; */ > >> + /* case PKT_RX_RECIP_ERR: return "PKT_RX_RECIP_ERR"; */ > >> + /* case PKT_RX_MAC_ERR: return "PKT_RX_MAC_ERR"; */ > > > > Didn't spot it before, wonder why do you need these 5 commented out lin= es? > > In fact, why do we need these flags if they all equal to zero right now= ? > > I know these flags were not introduced by that patch, in fact as I can = see it was a temporary measure, > > as old ol_flags were just 16 bits long: > > http://dpdk.org/ml/archives/dev/2014-June/003308.html > > So wonder should now these flags either get proper values or be removed= ? >=20 > I would be in favor of removing them, or at least the following ones > (I don't understand how they can help the application): >=20 > - PKT_RX_OVERSIZE: Num of desc of an RX pkt oversize. > - PKT_RX_HBUF_OVERFLOW: Header buffer overflow. > - PKT_RX_RECIP_ERR: Hardware processing error. > - PKT_RX_MAC_ERR: MAC error. Tend to agree... Or probably collapse these 4 flags into one: flag PKT_RX_ERR or something. Might be still used by someone for debugging purposes. Helin, what do you think? >=20 > I would have say that a statistics counter in the driver is more > appropriate for this case (maybe there is already a counter in the > hardware). >=20 > I have no i40e hardware to test that, so I don't feel very comfortable > to modify the i40e driver code to add these stats. >=20 > Adding Helin in CC list, maybe he has an idea. >=20 > Regards, > Olivier