From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 2F72B2A9 for ; Tue, 25 Nov 2014 11:26:47 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 25 Nov 2014 02:34:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,455,1413270000"; d="scan'208";a="613653739" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga001.jf.intel.com with ESMTP; 25 Nov 2014 02:37:35 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.144]) by IRSMSX107.ger.corp.intel.com ([169.254.10.117]) with mapi id 14.03.0195.001; Tue, 25 Nov 2014 10:37:34 +0000 From: "Ananyev, Konstantin" To: 'Olivier MATZ' , "'dev@dpdk.org'" Thread-Topic: [dpdk-dev] [PATCH v2 06/13] mbuf: add functions to get the name of an ol_flag Thread-Index: AQHQAC0gx1uA8Hd/WEmdIDKnZALmDZxlJ+CAgAD8JQCAAaggIIAJasXw Date: Tue, 25 Nov 2014 10:37:33 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213B958A@IRSMSX105.ger.corp.intel.com> References: <1415635166-1364-1-git-send-email-olivier.matz@6wind.com> <1415984609-2484-1-git-send-email-olivier.matz@6wind.com> <1415984609-2484-7-git-send-email-olivier.matz@6wind.com> <2601191342CEEE43887BDE71AB977258213AE5A1@IRSMSX105.ger.corp.intel.com> <546B1188.2090203@6wind.com> <2601191342CEEE43887BDE71AB977258213B6BDA@IRSMSX105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB977258213B6BDA@IRSMSX105.ger.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "'jigsaw@gmail.com'" Subject: Re: [dpdk-dev] [PATCH v2 06/13] mbuf: add functions to get the name of an ol_flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Nov 2014 10:26:48 -0000 Hi Helin, > -----Original Message----- > From: Ananyev, Konstantin > Sent: Wednesday, November 19, 2014 11:07 AM > To: Olivier MATZ; dev@dpdk.org > Cc: jigsaw@gmail.com; Zhang, Helin > Subject: RE: [dpdk-dev] [PATCH v2 06/13] mbuf: add functions to get the n= ame of an ol_flag >=20 >=20 >=20 > > -----Original Message----- > > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > > Sent: Tuesday, November 18, 2014 9:30 AM > > To: Ananyev, Konstantin; dev@dpdk.org > > Cc: jigsaw@gmail.com; Zhang, Helin > > Subject: Re: [dpdk-dev] [PATCH v2 06/13] mbuf: add functions to get the= name of an ol_flag > > > > Hi Konstantin, > > > > On 11/17/2014 08:00 PM, Ananyev, Konstantin wrote: > > >> +/* > > >> + * Get the name of a RX offload flag > > >> + */ > > >> +const char *rte_get_rx_ol_flag_name(uint64_t mask) > > >> +{ > > >> + switch (mask) { > > >> + case PKT_RX_VLAN_PKT: return "PKT_RX_VLAN_PKT"; > > >> + case PKT_RX_RSS_HASH: return "PKT_RX_RSS_HASH"; > > >> + case PKT_RX_FDIR: return "PKT_RX_FDIR"; > > >> + case PKT_RX_L4_CKSUM_BAD: return "PKT_RX_L4_CKSUM_BAD"; > > >> + case PKT_RX_IP_CKSUM_BAD: return "PKT_RX_IP_CKSUM_BAD"; > > >> + /* case PKT_RX_EIP_CKSUM_BAD: return "PKT_RX_EIP_CKSUM_BAD"; */ > > >> + /* case PKT_RX_OVERSIZE: return "PKT_RX_OVERSIZE"; */ > > >> + /* case PKT_RX_HBUF_OVERFLOW: return "PKT_RX_HBUF_OVERFLOW"; */ > > >> + /* case PKT_RX_RECIP_ERR: return "PKT_RX_RECIP_ERR"; */ > > >> + /* case PKT_RX_MAC_ERR: return "PKT_RX_MAC_ERR"; */ > > > > > > Didn't spot it before, wonder why do you need these 5 commented out l= ines? > > > In fact, why do we need these flags if they all equal to zero right n= ow? > > > I know these flags were not introduced by that patch, in fact as I ca= n see it was a temporary measure, > > > as old ol_flags were just 16 bits long: > > > http://dpdk.org/ml/archives/dev/2014-June/003308.html > > > So wonder should now these flags either get proper values or be remov= ed? > > > > I would be in favor of removing them, or at least the following ones > > (I don't understand how they can help the application): > > > > - PKT_RX_OVERSIZE: Num of desc of an RX pkt oversize. > > - PKT_RX_HBUF_OVERFLOW: Header buffer overflow. > > - PKT_RX_RECIP_ERR: Hardware processing error. > > - PKT_RX_MAC_ERR: MAC error. >=20 > Tend to agree... > Or probably collapse these 4 flags into one: flag PKT_RX_ERR or something= . > Might be still used by someone for debugging purposes. > Helin, what do you think? As there is no answer, I suppose you don't care these flags any more. So we can just remove them, right? Konstantin >=20 > > > > I would have say that a statistics counter in the driver is more > > appropriate for this case (maybe there is already a counter in the > > hardware). > > > > I have no i40e hardware to test that, so I don't feel very comfortable > > to modify the i40e driver code to add these stats. > > > > Adding Helin in CC list, maybe he has an idea. > > > > Regards, > > Olivier