From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 675B43F9 for ; Wed, 26 Nov 2014 11:39:01 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 26 Nov 2014 02:49:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,462,1413270000"; d="scan'208";a="638333128" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga002.fm.intel.com with ESMTP; 26 Nov 2014 02:49:54 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.144]) by IRSMSX152.ger.corp.intel.com ([169.254.6.56]) with mapi id 14.03.0195.001; Wed, 26 Nov 2014 10:49:53 +0000 From: "Ananyev, Konstantin" To: "Zhang, Helin" , "dev@dpdk.org" Thread-Topic: [PATCH] i40e: Use one bit flag for all hardware detected RX packet errors Thread-Index: AQHQCT9a48VJuIAuXkSUeu0M/l6yQJxyr+QQ Date: Wed, 26 Nov 2014 10:49:51 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213BA7CA@IRSMSX105.ger.corp.intel.com> References: <1416982032-28519-1-git-send-email-helin.zhang@intel.com> In-Reply-To: <1416982032-28519-1-git-send-email-helin.zhang@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] i40e: Use one bit flag for all hardware detected RX packet errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Nov 2014 10:39:02 -0000 Hi Helin, > -----Original Message----- > From: Zhang, Helin > Sent: Wednesday, November 26, 2014 6:07 AM > To: dev@dpdk.org > Cc: Cao, Waterman; Cao, Min; Ananyev, Konstantin; olivier.matz@6wind.com;= Zhang, Helin > Subject: [PATCH] i40e: Use one bit flag for all hardware detected RX pack= et errors >=20 > There were some bit flags of 0 for RX packet errors detected by hardware. > Actually only one bit of error flag is enough for all hardware detected > RX packet errors. >=20 > Signed-off-by: Helin Zhang > --- > lib/librte_mbuf/rte_mbuf.h | 6 +----- > lib/librte_pmd_i40e/i40e_rxtx.c | 31 +++---------------------------- > 2 files changed, 4 insertions(+), 33 deletions(-) >=20 > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > index 5899e5c..897fd26 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -80,11 +80,6 @@ extern "C" { > #define PKT_RX_FDIR (1ULL << 2) /**< RX packet with FDIR match= indicate. */ > #define PKT_RX_L4_CKSUM_BAD (1ULL << 3) /**< L4 cksum of RX pkt. is no= t OK. */ > #define PKT_RX_IP_CKSUM_BAD (1ULL << 4) /**< IP cksum of RX pkt. is no= t OK. */ > -#define PKT_RX_EIP_CKSUM_BAD (0ULL << 0) /**< External IP header checks= um error. */ > -#define PKT_RX_OVERSIZE (0ULL << 0) /**< Num of desc of an RX pkt = oversize. */ > -#define PKT_RX_HBUF_OVERFLOW (0ULL << 0) /**< Header buffer overflow. *= / > -#define PKT_RX_RECIP_ERR (0ULL << 0) /**< Hardware processing error= . */ > -#define PKT_RX_MAC_ERR (0ULL << 0) /**< MAC error. */ > #define PKT_RX_IPV4_HDR (1ULL << 5) /**< RX packet with IPv4 heade= r. */ > #define PKT_RX_IPV4_HDR_EXT (1ULL << 6) /**< RX packet with extended I= Pv4 header. */ > #define PKT_RX_IPV6_HDR (1ULL << 7) /**< RX packet with IPv6 heade= r. */ > @@ -95,6 +90,7 @@ extern "C" { > #define PKT_RX_TUNNEL_IPV6_HDR (1ULL << 12) /**< RX tunnel packet with I= Pv6 header. */ > #define PKT_RX_FDIR_ID (1ULL << 13) /**< FD id reported if FDIR ma= tch. */ > #define PKT_RX_FDIR_FLX (1ULL << 14) /**< Flexible bytes reported i= f FDIR match. */ > +#define PKT_RX_ERR_HW (1ULL << 15) /**< RX packet error detected = by hardware. */ >=20 > #define PKT_TX_VLAN_PKT (1ULL << 55) /**< TX packet is a 802.1q VLA= N packet. */ > #define PKT_TX_IP_CKSUM (1ULL << 54) /**< IP cksum of TX pkt. compu= ted by NIC. */ > diff --git a/lib/librte_pmd_i40e/i40e_rxtx.c b/lib/librte_pmd_i40e/i40e_r= xtx.c > index cce6911..3b2195d 100644 > --- a/lib/librte_pmd_i40e/i40e_rxtx.c > +++ b/lib/librte_pmd_i40e/i40e_rxtx.c > @@ -115,35 +115,10 @@ i40e_rxd_status_to_pkt_flags(uint64_t qword) > static inline uint64_t > i40e_rxd_error_to_pkt_flags(uint64_t qword) > { > - uint64_t flags =3D 0; > - uint64_t error_bits =3D (qword >> I40E_RXD_QW1_ERROR_SHIFT); > - > -#define I40E_RX_ERR_BITS 0x3f > - if (likely((error_bits & I40E_RX_ERR_BITS) =3D=3D 0)) > - return flags; > - /* If RXE bit set, all other status bits are meaningless */ > - if (unlikely(error_bits & (1 << I40E_RX_DESC_ERROR_RXE_SHIFT))) { > - flags |=3D PKT_RX_MAC_ERR; > - return flags; > - } > - > - /* If RECIPE bit set, all other status indications should be ignored */ > - if (unlikely(error_bits & (1 << I40E_RX_DESC_ERROR_RECIPE_SHIFT))) { > - flags |=3D PKT_RX_RECIP_ERR; > - return flags; > - } > - if (unlikely(error_bits & (1 << I40E_RX_DESC_ERROR_HBO_SHIFT))) > - flags |=3D PKT_RX_HBUF_OVERFLOW; > - if (unlikely(error_bits & (1 << I40E_RX_DESC_ERROR_IPE_SHIFT))) > - flags |=3D PKT_RX_IP_CKSUM_BAD; > - if (unlikely(error_bits & (1 << I40E_RX_DESC_ERROR_L4E_SHIFT))) > - flags |=3D PKT_RX_L4_CKSUM_BAD; > - if (unlikely(error_bits & (1 << I40E_RX_DESC_ERROR_EIPE_SHIFT))) > - flags |=3D PKT_RX_EIP_CKSUM_BAD; > - if (unlikely(error_bits & (1 << I40E_RX_DESC_ERROR_OVERSIZE_SHIFT))) > - flags |=3D PKT_RX_OVERSIZE; > + if (unlikely(qword & I40E_RXD_QW1_ERROR_MASK)) > + return PKT_RX_ERR_HW; Probably I didn't explain myself clear enough, sorry. I didn't suggest to get rid of setting bits that indicate L3/L4 checksum er= rors: PKT_RX_IP_CKSUM_BAD, PKT_RX_L4_CKSUM_BAD, PKT_RX_EIP_CKSUM_BAD. I think these flags should be set as before. I was talking only about collapsing only these 4 RX error flags into one: #define PKT_RX_OVERSIZE (0ULL << 0) /**< Num of desc of an RX pkt ove= rsize. */ #define PKT_RX_HBUF_OVERFLOW (0ULL << 0) /**< Header buffer overflow. */ #define PKT_RX_RECIP_ERR (0ULL << 0) /**< Hardware processing error. *= / #define PKT_RX_MAC_ERR (0ULL << 0) /**< MAC error. */=20 >>From my point of view the difference of these 2 groups are: First - HW was able to receive whole packet without a problem, but L3/L4 ch= ecksum check failed. Second - HW was not able to receive whole packet properly by whatever reaso= n.=20 >>From upper layer SW perspective - there it probably makes little difference= , what caused it, as most likely SW has to throw away erroneous packet.=20 And for debugging purposes, we can add PMD_LOG(DEBUG, ...) that would print= what exactly HW error happened. Thanks Konstantin >=20 > - return flags; > + return 0; > } >=20 > /* Translate pkt types to pkt flags */ > -- > 1.8.1.4