From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id BCF5E5931 for ; Fri, 28 Nov 2014 12:13:56 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 28 Nov 2014 03:13:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,476,1413270000"; d="scan'208";a="639508333" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga002.fm.intel.com with ESMTP; 28 Nov 2014 03:13:38 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.144]) by IRSMSX104.ger.corp.intel.com ([169.254.5.209]) with mapi id 14.03.0195.001; Fri, 28 Nov 2014 11:13:37 +0000 From: "Ananyev, Konstantin" To: Olivier MATZ , "Liu, Jijiang" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags and change three fields Thread-Index: AQHQCu8HtybaEe97F0+AWT7gU9Fz85x1140AgAAAoHCAAAb6gIAAAqBg Date: Fri, 28 Nov 2014 11:13:37 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213BB258@IRSMSX105.ger.corp.intel.com> References: <1417107801-9544-1-git-send-email-jijiang.liu@intel.com> <1417107801-9544-2-git-send-email-jijiang.liu@intel.com> <54784232.8030707@6wind.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01D9F2B9@SHSMSX101.ccr.corp.intel.com> <2601191342CEEE43887BDE71AB977258213BB218@IRSMSX105.ger.corp.intel.com> <547855C9.80507@6wind.com> In-Reply-To: <547855C9.80507@6wind.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags and change three fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Nov 2014 11:13:57 -0000 > -----Original Message----- > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > Sent: Friday, November 28, 2014 11:00 AM > To: Ananyev, Konstantin; Liu, Jijiang; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags an= d change three fields >=20 > Hi Konstantin, >=20 > On 11/28/2014 11:40 AM, Ananyev, Konstantin wrote: > > > > Well, I still prefer them to be mutually exclusive. > > Even better, if we can squeeze these 3 flags into 2 bits. > > Would save us 2 bits, plus might be handy, as in the PMD you can do: > > > > switch (ol_flags & TX_L3_MASK) { > > case TX_IPV4: > > ... > > break; > > case TX_IPV6: > > ... > > break; > > case TX_IP_CKSUM: > > ... > > break; > > } > > > > For the upper layer, I think there would be no big difference, what way= s we will choose. >=20 > I think the 2 informations are transversal, and that's why I would > prefer 2 flags. Also, having 2 separate flags would also help to keep > backward compatibility with previous versions. Hmm, not sure how we will break compatibility in that case? If we'll make TX_IP_CKSUM to be 1 bit value (1 << X) then for current drive= rs nothing should change, no? >=20 > It may help to have other points of view to make the good decision. > I'll follow the majority. >=20 > Regards, > Olivier