From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A0F0E58E8 for ; Fri, 28 Nov 2014 16:46:53 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 28 Nov 2014 07:46:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="422702886" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by FMSMGA003.fm.intel.com with ESMTP; 28 Nov 2014 07:36:54 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.144]) by IRSMSX102.ger.corp.intel.com ([169.254.2.93]) with mapi id 14.03.0195.001; Fri, 28 Nov 2014 15:46:50 +0000 From: "Ananyev, Konstantin" To: Olivier MATZ , "Liu, Jijiang" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags and change three fields Thread-Index: AQHQCu8HtybaEe97F0+AWT7gU9Fz85x1140AgAAAoHCAAAb6gIAAAqBggAACgICAAEog4A== Date: Fri, 28 Nov 2014 15:46:49 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213BB40F@IRSMSX105.ger.corp.intel.com> References: <1417107801-9544-1-git-send-email-jijiang.liu@intel.com> <1417107801-9544-2-git-send-email-jijiang.liu@intel.com> <54784232.8030707@6wind.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01D9F2B9@SHSMSX101.ccr.corp.intel.com> <2601191342CEEE43887BDE71AB977258213BB218@IRSMSX105.ger.corp.intel.com> <547855C9.80507@6wind.com> <2601191342CEEE43887BDE71AB977258213BB258@IRSMSX105.ger.corp.intel.com> <54785A15.1090301@6wind.com> In-Reply-To: <54785A15.1090301@6wind.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags and change three fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Nov 2014 15:46:54 -0000 > -----Original Message----- > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > Sent: Friday, November 28, 2014 11:19 AM > To: Ananyev, Konstantin; Liu, Jijiang; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags an= d change three fields >=20 > Hi Konstantin, >=20 > On 11/28/2014 12:13 PM, Ananyev, Konstantin wrote: > >>> For the upper layer, I think there would be no big difference, what w= ays we will choose. > >> > >> I think the 2 informations are transversal, and that's why I would > >> prefer 2 flags. Also, having 2 separate flags would also help to keep > >> backward compatibility with previous versions. > > > > Hmm, not sure how we will break compatibility in that case? > > If we'll make TX_IP_CKSUM to be 1 bit value (1 << X) then for current d= rivers nothing should change, no? >=20 > Yes, you're right, sorry. Actually, you right - squeezing these 3 flags into 2 bits would break back= ward compatibility. Sorry, didn't think properly. Konstantin >=20 > Olivier