From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id D227D9A8 for ; Sun, 30 Nov 2014 15:50:35 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 30 Nov 2014 06:43:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="423227911" Received: from irsmsx155.ger.corp.intel.com ([163.33.192.3]) by FMSMGA003.fm.intel.com with ESMTP; 30 Nov 2014 06:40:29 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.144]) by IRSMSX155.ger.corp.intel.com ([169.254.14.228]) with mapi id 14.03.0195.001; Sun, 30 Nov 2014 14:50:32 +0000 From: "Ananyev, Konstantin" To: Olivier MATZ , "Liu, Jijiang" Thread-Topic: [dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change three fields Thread-Index: AQHQCikb8nVQX/4wQEWUH1iPbQ9du5x0gSyAgAABBFCAAC/e0IABKpkAgANkFaA= Date: Sun, 30 Nov 2014 14:50:32 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213BB795@IRSMSX105.ger.corp.intel.com> References: <1417076319-629-1-git-send-email-jijiang.liu@intel.com> <1417076319-629-2-git-send-email-jijiang.liu@intel.com> <5476F626.2020708@6wind.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01D9EEA0@SHSMSX101.ccr.corp.intel.com> <2601191342CEEE43887BDE71AB977258213BADB8@IRSMSX105.ger.corp.intel.com> <2601191342CEEE43887BDE71AB977258213BAE90@IRSMSX105.ger.corp.intel.com> <54785264.1020208@6wind.com> In-Reply-To: <54785264.1020208@6wind.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change three fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Nov 2014 14:50:37 -0000 Hi Olver, > -----Original Message----- > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > Sent: Friday, November 28, 2014 10:46 AM > To: Ananyev, Konstantin; Liu, Jijiang > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and cha= nge three fields >=20 > Hi Konstantin, >=20 > On 11/27/2014 06:01 PM, Ananyev, Konstantin wrote: > >> Yes, I think it could be done that way too. > >> Though I still prefer to keep l4tun_len - it makes things a bit cleane= r (at least to me). > >> After all we do have space for it in mbuf's tx_offload. > > > > As one more thing in favour of separate l4tun_len field: > > l2_len is 7 bit long, so in theory it might be not enough, as for FVL: > > 12:18 L4TUNLEN L4 Tunneling Length (Teredo / GRE header / VXLAN header)= defined in Words. >=20 > The l2_len field is 7 bits long because it was mapped to ixgbe hardware. > If it's not enough (although I'm not sure it's possible to have a header > larger than 128 bytes in this case), it's probably because we should > not have been doing that. > Maybe these generic fields should be generic :) > If it's not enough, what about changing l2_len to 8 bits? >=20 > Often in the recent discussions, I see as an argument "fortville needs > this so we need to add it in the mbuf". I agree that currently > fortville is the only hardware supported for the new features, so it > can make sense to act like this, but we have to accept to come back > to this API in the future if it makes less sense with other drivers. >=20 > Also, application developers can be annoyed to see that the mbuf flags > and meta data are just duplicating information that is already present > in the packet. >=20 > About the l4tun_len, it's another field the application has to fill, > but it's maybe cleaner. I just wanted to clarify why I'm discussing > these points. After another thought, I think that the way you proposed is a better one. I gives us more flexibility: =20 let's say for now we'll keep both l2_len and outer_l2_len as 7 bit fields, and upper layer would have to: mb->l2_len =3D eth_hdr_in + vxlan_hdr; for VXLAN packets. Then if in the future, we'll realise that 7 bit is not enough we can either= : - increase size of l2_len and outer_l2_len - introduce new field (l4tun_len as we planned now) In both cases backward compatibility wouldn't be affected. >>From other side - if we'' introduce a new field now (l4tun_len), it would b= e very hard to get rid of it in the future. =20 So, I think we'd better follow your approach here. Thanks Konstantin >=20 > Regards, > Olivier