From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C71FCDE0 for ; Tue, 2 Dec 2014 14:16:03 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 02 Dec 2014 05:16:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,501,1413270000"; d="scan'208";a="641336398" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga002.fm.intel.com with ESMTP; 02 Dec 2014 05:16:01 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.144]) by IRSMSX102.ger.corp.intel.com ([169.254.2.93]) with mapi id 14.03.0195.001; Tue, 2 Dec 2014 13:16:00 +0000 From: "Ananyev, Konstantin" To: "Zhang, Helin" , "dev@dpdk.org" Thread-Topic: [PATCH v8 0/4] Support configuring hash functions Thread-Index: AQHQDdZrv9dEte8/00idu8qPpRGKQpx8SF4Q Date: Tue, 2 Dec 2014 13:15:59 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213BBFD8@IRSMSX105.ger.corp.intel.com> References: <1417176852-12345-1-git-send-email-helin.zhang@intel.com> <1417486760-24459-1-git-send-email-helin.zhang@intel.com> In-Reply-To: <1417486760-24459-1-git-send-email-helin.zhang@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v8 0/4] Support configuring hash functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Dec 2014 13:16:04 -0000 > -----Original Message----- > From: Zhang, Helin > Sent: Tuesday, December 02, 2014 2:19 AM > To: dev@dpdk.org > Cc: Cao, Waterman; Cao, Min; Ananyev, Konstantin; Zhang, Helin > Subject: [PATCH v8 0/4] Support configuring hash functions >=20 > These patches mainly support configuring hash functions. In detail, > - It can get/set global hash configurations. > * Get/set symmetric hash enable per flow type. > * Get/set hash function type. > - It can get/set symmetric hash enable per port. > - Four commands have been implemented in testpmd to support testing abov= e. > * get_sym_hash_ena_per_port > * set_sym_hash_ena_per_port > * get_hash_global_config > * set_hash_global_config >=20 > It also uses constant hash keys to replace runtime generating hash keys. > Global initialization is added to correctly put registers to an initial s= tate. >=20 > v3 changes: > * Removed renamings in rte_ethdev.h. > * Redesigned filter control API and its relevant structures/enums. > * Renamed header file from rte_eth_features.h to rte_eth_ctrol.h. > * Remove public header file of rte_i40e.h specific for i40e. > * Added hardware initialization function during port init. > * Used constant random hash keys in i40e PF. > * renamed the commands in testpmd based on the redesigned filter control = API. >=20 > v4 changes: > * Fixed a bug in testpmd to support 'set_sym_hash_ena_per_port'. >=20 > v5 changes: > * Integrated with filter API defined recently. > * Remove all for filter API definition, as it has already defined and mer= ged > recently. >=20 > v6 changes: > * Flow type strings are used to replace Packet Classification Types, to i= solate > hardware specific things. > * Implemented the mapping function to convert RSS offload types to Packet > Classification Types, to isolate the real hardware specific things. > * Removed initialization of global registers in i40e PMD, as global regis= ters > shouldn't be initialized per port. > * Added more annotations to get code more understandable. > * Corrected annotation format for documenation. >=20 > v7 changes: > * Removed swap configurations, as it is not allowed by hardware design. > * Put symmetric hash per flow type and hash function type into > 'RTE_ETH_HASH_FILTER_GLOBAL_CONFIG', as they are controlling global reg= isters > which will affects all the ports of the same NIC. >=20 > v8 changes: > * Removed redundant checks in i40e_ethdev.c. > * Solved compile errors on ICC. >=20 > Helin Zhang (4): > ethdev: code style fixes > i40e: use constant as the default hash keys > i40e: support of controlling hash functions > app/testpmd: add commands to support hash functions >=20 > app/test-pmd/cmdline.c | 333 ++++++++++++++++++++++++++++++++= ++++++ > lib/librte_ether/rte_eth_ctrl.h | 72 ++++++++- > lib/librte_pmd_i40e/i40e_ethdev.c | 308 ++++++++++++++++++++++++++++++++= +-- > 3 files changed, 699 insertions(+), 14 deletions(-) >=20 > -- > 1.8.1.4 Acked-by: Konstantin Ananyev