From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id BD6957F50 for ; Tue, 2 Dec 2014 16:40:28 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 02 Dec 2014 07:33:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,501,1413270000"; d="scan'208";a="631434991" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by fmsmga001.fm.intel.com with ESMTP; 02 Dec 2014 07:40:22 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.144]) by IRSMSX109.ger.corp.intel.com ([169.254.13.244]) with mapi id 14.03.0195.001; Tue, 2 Dec 2014 15:40:19 +0000 From: "Ananyev, Konstantin" To: "Liu, Jijiang" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v5 0/3] i40e VXLAN TX checksum rework Thread-Index: AQHQDkGo4UzYjf9bTkmwsI+SWY2BlJx8b/Fw Date: Tue, 2 Dec 2014 15:40:19 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213BC0A5@IRSMSX105.ger.corp.intel.com> References: <1417532767-1309-1-git-send-email-jijiang.liu@intel.com> In-Reply-To: <1417532767-1309-1-git-send-email-jijiang.liu@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 0/3] i40e VXLAN TX checksum rework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Dec 2014 15:40:31 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu > Sent: Tuesday, December 02, 2014 3:06 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v5 0/3] i40e VXLAN TX checksum rework >=20 > We have got some feedback about backward compatibility of VXLAN TX checks= um offload API with 1G/10G NIC after the i40e VXLAN > TX checksum codes were applied, so we have to rework the APIs on i40e, in= cluding the changes of mbuf, i40e PMD and csum forward > engine. >=20 > The main changes in mbuf are as follows, in place of removing PKT_TX_VXLA= N_CKSUM, we introduce 4 new flags: > PKT_TX_OUTER_IP_CKSUM, PKT_TX_OUTER_IPV4, PKT_TX_OUTER_IPV6 and PKT_TX_UD= P_TUNNEL_PKT. Replace the inner_l2_len > and the inner_l3_len field with the outer_l2_len and outer_l3_len field. >=20 > Let's use a few examples to demonstrate how to use these new flags and ex= isting flags in rte_mbuf.h > Let say we have a tunnel packet: eth_hdr_out/ipv4_hdr_out/udp_hdr_out/vxl= an_hdr/ehtr_hdr_in/ipv4_hdr_in/tcp_hdr_in. There > could be several scenarios: >=20 > A) User requests HW offload for ipv4_hdr_out checksum. > He doesn't care is it a tunnelled packet or not. So he sets: >=20 > mb->l2_len =3D eth_hdr_out; > mb->l3_len =3D ipv4_hdr_out; > mb->ol_flags |=3D PKT_TX_IPV4_CSUM; >=20 > B) User is aware that it is a tunnelled packet and requests HW offload fo= r ipv4_hdr_in and tcp_hdr_in *only*. > He doesn't care about outer IP checksum offload. In that case, for FVL h= e has 2 choices: > 1. Treat that packet as a 'proper' tunnelled packet, and fill all the = fields: > mb->l2_len =3D udp_hdr_out + vxlan_hdr +eth_hdr_in; > mb->l3_len =3D ipv4_hdr_in; > mb->outer_l2_len =3D eth_hdr_out; > mb->outer_l3_len =3D ipv4_hdr_out; > mb->ol_flags |=3D PKT_TX_UDP_TUNNEL_PKT | PKT_TX_IP_CKSUM | PKT_TX_= TCP_CKSUM; >=20 > 2. As user doesn't care about outer IP hdr checksum, he can treat ever= ything before ipv4_hdr_in as L2 header. > So he knows, that it is a tunnelled packet, but makes HW to treat it a= s ordinary (non-tunnelled) packet: > mb->l2_len =3D eth_hdr_out + ipv4_hdr_out + udp_hdr_out + vxlan_hdr = + ehtr_hdr_in; > mb->l3_len =3D ipv4_hdr_in; > mb->ol_flags |=3D PKT_TX_IP_CKSUM | PKT_TX_TCP_CKSUM; >=20 > i40e PMD will support both B.1 and B.2, but ixgbe/igb/em PMD supports onl= y B.2. > if HW supports both - it will be up to user app which method to choose. > tespmd will support both methods, and it should be configurable by user w= hich approach to use (cmdline parameter). > So the user can try/test both methods and select an appropriate for him. >=20 > C) User knows that is a tunnelled packet, and wants HW offload for all 3 = checksums: outer IP hdr checksum, inner IP checksum, inner > TCP checksum. > Then he has to setup all TX checksum fields: > mb->l2_len =3D udp_hdr_out + vxlan_hdr +eth_hdr_in;; > mb->l3_len =3D ipv4_hdr_in; > mb->outer_l2_len =3D eth_hdr_out; > mb->outer_l3_len =3D ipv4_hdr_out; > mb->ol_flags |=3D PKT_TX_OUT_IP_CKSUM | PKT_TX_UDP_TUNNEL_PKT | PKT= _TX_IP_CKSUM | PKT_TX_TCP_CKSUM; >=20 > Change notes: > v2 changes: > remove PKT_TX_IP_CKSUM alias. > add PKT_TX_OUT_IP_CKSUM and PKT_TX_OUTER_IPV6 in rte_get_tx_ol_flag_= name. > spliting mbuf changes into two patches. > fix MACLEN caculation issue in i40e driver > fix some issues in csumonly.c > change cover letter. > v3 changes: > fix MACLEN caculation issue in i40e driver when non-tunneling packet > v4 changes: > reorganize patches to avoid compilation to be broken between patches= . > remove l4_tun_len from mbuf structure. > add PKT_TX_OUTER_IPV4 to indicate no IP checksum offload requirement= for tunneling packet. > change i40e PMD and csum engine due to above changes. >=20 > v5 changes: > according to Konstantin's comments, optimize process_outer_cksums() = in order to avoid setting PKT_TX_OUTER_IPV4 flags for the > case when user didn't enable TESTPMD_TX_OFFLOAD_VXLAN_CKSUM >=20 > Jijiang Liu (3): > Redefine PKT_TX_IPV4, PKT_TX_IPV6 and PKT_TX_VLAN_PKT; > Replace PKT_TX_VXLAN_CKSUM with PKT_TX_UDP_TUNNEL_PKT, and add 3 TX fla= gs, which are PKT_TX_OUTER_IP_CKSUM, > PKT_TX_OUTER_IPV4 and PKT_TX_OUTER_IPV6,and rework csum forward engine an= d i40e pmd due to these changes; > Replace the inner_l2_len and the inner_l3_len field with the outer_l2_l= en and outer_l3_len field, and rework csum forward engine > and i40e pmd due to these changes; >=20 > app/test-pmd/csumonly.c | 69 ++++++++++++++++++++++-----------= ----- > lib/librte_mbuf/rte_mbuf.c | 7 +++- > lib/librte_mbuf/rte_mbuf.h | 25 +++++++++---- > lib/librte_pmd_i40e/i40e_rxtx.c | 44 +++++++++++++------------ > 4 files changed, 86 insertions(+), 59 deletions(-) >=20 > -- > 1.7.7.6 Acked-by: Konstantin Ananyev