From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 59B2A8040 for ; Thu, 4 Dec 2014 15:43:14 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 04 Dec 2014 06:42:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,691,1406617200"; d="scan'208";a="493587676" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga003.jf.intel.com with ESMTP; 04 Dec 2014 06:39:34 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.144]) by IRSMSX109.ger.corp.intel.com ([169.254.13.244]) with mapi id 14.03.0195.001; Thu, 4 Dec 2014 14:42:55 +0000 From: "Ananyev, Konstantin" To: "Richardson, Bruce" , Jean-Mickael Guerin Thread-Topic: [dpdk-dev] [PATCH 1/2] ixgbe: fix setup of mbuf initializer template Thread-Index: AQHQD9B5OmH5S3/730anOnBUr/a3RZx/gWDw Date: Thu, 4 Dec 2014 14:42:54 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213BCA09@IRSMSX105.ger.corp.intel.com> References: <1417703181-23093-1-git-send-email-jean-mickael.guerin@6wind.com> <1417703181-23093-2-git-send-email-jean-mickael.guerin@6wind.com> <20141204143930.GA9300@bricha3-MOBL3> In-Reply-To: <20141204143930.GA9300@bricha3-MOBL3> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/2] ixgbe: fix setup of mbuf initializer template X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Dec 2014 14:43:15 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > Sent: Thursday, December 04, 2014 2:40 PM > To: Jean-Mickael Guerin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] ixgbe: fix setup of mbuf initializer = template >=20 > On Thu, Dec 04, 2014 at 03:26:20PM +0100, Jean-Mickael Guerin wrote: > > Add a compiler barrier to make sure all fields covered by > > the marker rearm_data are assigned before the read. > > > > Signed-off-by: Jean-Mickael Guerin > > Acked-by: David Marchand > > Fixes: 0ff3324da2 ("ixgbe: rework vector pmd following mbuf changes") >=20 > Acked-by: Bruce Richardson >=20 > > --- > > lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c b/lib/librte_pmd_ixg= be/ixgbe_rxtx_vec.c > > index 579bc46..c1b5a78 100644 > > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c > > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c > > @@ -739,6 +739,9 @@ ixgbe_rxq_vec_setup(struct igb_rx_queue *rxq) > > mb_def.buf_len =3D rxq->mb_pool->elt_size - sizeof(struct rte_mbuf); > > mb_def.port =3D rxq->port_id; > > rte_mbuf_refcnt_set(&mb_def, 1); > > + > > + /* prevent compiler reordering: rearm_data covers previous fields */ > > + rte_compiler_barrier(); > > rxq->mbuf_initializer =3D *((uint64_t *)&mb_def.rearm_data); > > return 0; > > } > > -- Hmm, can someone explain to me why do we need a compiler barrier here? Konstantin > > 2.1.3 > >