From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 2BFCE803D for ; Thu, 4 Dec 2014 15:50:38 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 04 Dec 2014 06:49:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,515,1413270000"; d="scan'208";a="618596007" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga001.jf.intel.com with ESMTP; 04 Dec 2014 06:50:13 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.144]) by IRSMSX102.ger.corp.intel.com ([169.254.2.93]) with mapi id 14.03.0195.001; Thu, 4 Dec 2014 14:50:12 +0000 From: "Ananyev, Konstantin" To: Jean-Mickael Guerin , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length Thread-Index: AQHQD85vrzKVJNav6E2ecmauZYfKoZx/gkeg Date: Thu, 4 Dec 2014 14:50:11 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213BCA29@IRSMSX105.ger.corp.intel.com> References: <1417703181-23093-1-git-send-email-jean-mickael.guerin@6wind.com> <1417703181-23093-3-git-send-email-jean-mickael.guerin@6wind.com> In-Reply-To: <1417703181-23093-3-git-send-email-jean-mickael.guerin@6wind.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Dec 2014 14:50:39 -0000 Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jean-Mickael Guerin > Sent: Thursday, December 04, 2014 2:26 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length >=20 > The template mbuf_initializer is hard coded with a buflen which > might have been set differently by the application at the time of > mbuf pool creation. >=20 > Switch to a mbuf allocation, to fetch the correct default values. > There is no performance impact because this is not a data-plane API. >=20 > Signed-off-by: Jean-Mickael Guerin > Acked-by: David Marchand > Fixes: 0ff3324da2 ("ixgbe: rework vector pmd following mbuf changes") > --- > lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) >=20 > diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c b/lib/librte_pmd_ixgbe= /ixgbe_rxtx_vec.c > index c1b5a78..f7b02f5 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c > @@ -732,17 +732,22 @@ static struct ixgbe_txq_ops vec_txq_ops =3D { > int > ixgbe_rxq_vec_setup(struct igb_rx_queue *rxq) > { > - struct rte_mbuf mb_def =3D { .buf_addr =3D 0 }; /* zeroed mbuf */ > + struct rte_mbuf *mb_def; >=20 > - mb_def.nb_segs =3D 1; > - mb_def.data_off =3D RTE_PKTMBUF_HEADROOM; > - mb_def.buf_len =3D rxq->mb_pool->elt_size - sizeof(struct rte_mbuf); > - mb_def.port =3D rxq->port_id; > - rte_mbuf_refcnt_set(&mb_def, 1); > + mb_def =3D rte_pktmbuf_alloc(rxq->mb_pool); Could you explain to me, what is an advantage of using dynamic allocation v= s local struct here? I don't see any. Plus if rte_pktmbuf_alloc() would fail, we'll leave our rx queue not config= ured properly. As I can see ixgbe_dev_rx_queue_setup() doesn't check the return value of >= ixgbe_rxq_vec_setup() (as it is just not supposed to fail). So ixgbe_dev_rx_queue_setup() will return OK for unconfigured RX queue. > + if (mb_def =3D=3D NULL) { > + PMD_INIT_LOG(ERR, "ixgbe_rxq_vec_setup: could not allocate one mbuf"); > + return -1; > + } > + /* nb_segs, refcnt, data_off and buf_len are already set */ > + mb_def->port =3D rxq->port_id; >=20 > /* prevent compiler reordering: rearm_data covers previous fields */ > rte_compiler_barrier(); I don't think we need it here. > - rxq->mbuf_initializer =3D *((uint64_t *)&mb_def.rearm_data); > + rxq->mbuf_initializer =3D *((uint64_t *)&mb_def->rearm_data); > + > + rte_pktmbuf_free(mb_def); > + > return 0; > } >=20 > -- > 2.1.3 Somy vote - NACK for the whole series. Konstantin