From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id B24CD7E75 for ; Thu, 4 Dec 2014 22:42:59 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 04 Dec 2014 13:41:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,518,1413270000"; d="scan'208";a="618829577" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga001.jf.intel.com with ESMTP; 04 Dec 2014 13:42:57 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.144]) by IRSMSX109.ger.corp.intel.com ([169.254.13.244]) with mapi id 14.03.0195.001; Thu, 4 Dec 2014 21:42:56 +0000 From: "Ananyev, Konstantin" To: Olivier MATZ , "Zhang, Helin" , "Liu, Jijiang" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v5 2/3] mbuf:add three TX ol_flags and repalce PKT_TX_VXLAN_CKSUM Thread-Index: AQHQDu5Csn4rdRtSMEuKWiThOnkfhJx9Tg+AgAAcbICAAZPxgIAAOlhwgAA7GgCAAIN0IA== Date: Thu, 4 Dec 2014 21:42:56 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213BCC3B@IRSMSX105.ger.corp.intel.com> References: <1417532767-1309-1-git-send-email-jijiang.liu@intel.com> <1417532767-1309-3-git-send-email-jijiang.liu@intel.com> <547EF6E9.5040000@6wind.com> <2601191342CEEE43887BDE71AB977258213BC46D@IRSMSX105.ger.corp.intel.com> <547F211B.3040905@6wind.com> <2601191342CEEE43887BDE71AB977258213BC6D5@IRSMSX105.ger.corp.intel.com> <548065FA.6040105@6wind.com> In-Reply-To: <548065FA.6040105@6wind.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 2/3] mbuf:add three TX ol_flags and repalce PKT_TX_VXLAN_CKSUM X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Dec 2014 21:43:00 -0000 > -----Original Message----- > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > Sent: Thursday, December 04, 2014 1:48 PM > To: Ananyev, Konstantin; Zhang, Helin; Liu, Jijiang; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 2/3] mbuf:add three TX ol_flags and rep= alce PKT_TX_VXLAN_CKSUM >=20 > Hi, >=20 > On 12/04/2014 11:19 AM, Ananyev, Konstantin wrote: > >>> 1/ (Jijiang's patch) > >>> PKT_TX_IP_CKSUM /* packet is IPv4, and we want hw cksum */ > >>> PKT_TX_IPV6 /* packet is IPv6 */ > >>> PKT_TX_IPV4 /* packet is IPv4, and we don't want hw cksum */ > >>> > >>> with PKT_TX_IP_CKSUM and PKT_TX_IPV4 exclusive > >>> > >>> and > >>> > >>> 2/ > >>> PKT_TX_IP_CKSUM /* we want hw IP cksum */ > >>> PKT_TX_IPV6 /* packet is IPv6 */ > >>> PKT_TX_IPV4 /* packet is IPv4 */ > >> There is another bit flag named 'PKT_TX_IPV4_CSUM' which uses the > >> same bit of 'PKT_TX_IP_CSUM'. It is for identifying if ipv4 hardware > >> checksum offload is needed or not. > > > > Yes, 'PKT_TX_IPV4_CSUM is an alias to PKT_TX_IP_CKSUM and we are going= to remove it. > > > >> It seems that we do not need 'PKT_TX_IPV6_CSUM'. > > > > No one even planned it. > > > >> 'PKT_TX_IPV4' and 'PKT_TX_IPV6' just indicates its packet type, and I = guess > >> other features should not be contained in it, according to its name. > >> > >> So here I got the option 3: > >> PKT_TX_IPV4_CKSUM /* we want hw IPv4 cksum */ > >> PKT_TX_IPV6 /* packet is IPv6 */ > >> PKT_TX_IPV4 /* packet is IPv4 */ > > > > Hmm, and how this is different from what we have now in the Jijiang's p= atch? > > Except that you renamed PKT_TX_IP_CKSUM to PKT_TX_IPV4_CKSUM? >=20 > I think it's more like solution 2 with a renaming. And it is more > coherent to always have "IPV4" on all flag names. About renaming PKT_TX_IP_CKSUM to PKT_TX_IPV4_CKSUM: I don't mind. But that means we would have to update all the drivers and apps that using = PKT_TX_IP_CKSUM. Again there are customers that using that flag in their apps right now. They would have to change it too. For me - too much hassle for such small nit. Konstantin >=20 > Regards, > Olivier