From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C0FAB3F9 for ; Tue, 9 Dec 2014 15:50:58 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 09 Dec 2014 06:50:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="426926435" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by FMSMGA003.fm.intel.com with ESMTP; 09 Dec 2014 06:40:18 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.144]) by IRSMSX101.ger.corp.intel.com ([169.254.1.126]) with mapi id 14.03.0195.001; Tue, 9 Dec 2014 14:50:56 +0000 From: "Ananyev, Konstantin" To: "Liu, Jijiang" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 0/3] enhance TX checksum command and csum forwarding engine Thread-Index: AQHQE7K5Te3ydaJLMUO1OFLZXnnt8JyHV1hw Date: Tue, 9 Dec 2014 14:50:55 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213BE630@IRSMSX105.ger.corp.intel.com> References: <1418131068-7657-1-git-send-email-jijiang.liu@intel.com> In-Reply-To: <1418131068-7657-1-git-send-email-jijiang.liu@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 0/3] enhance TX checksum command and csum forwarding engine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Dec 2014 14:50:59 -0000 > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu > Sent: Tuesday, December 09, 2014 1:18 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 0/3] enhance TX checksum command and csum f= orwarding engine >=20 > In the current codes, the "tx_checksum set (ip|udp|tcp|sctp|vxlan) (hw|sw= ) (port-id)" command is not easy to understand and > extend, so the patch set enhances the tx_checksum command and reworks csu= m forwarding engine due to the change of > tx_checksum command. > The main changes of the tx_checksum command are listed below, >=20 > 1> add "tx_checksum set tunnel (hw|sw|none) (port-id)" command >=20 > The command is used to set/clear tunnel flag that is used to tell the NIC= that the packetg is a tunneing packet and application want > hardware TX checksum offload for outer layer, or inner layer, or both. >=20 > The 'none' option means that user treat tunneling packet as ordinary pack= et when using the csum forward engine. > for example, let say we have a tunnel packet: > eth_hdr_out/ipv4_hdr_out/udp_hdr_out/vxlan_hdr/ehtr_hdr_in/ipv4_hdr_in/tc= p_hdr_in. one of several scenarios: >=20 > 1) User requests HW offload for ipv4_hdr_out checksum, and doesn't care = is it a tunnelled packet or not. So he sets: >=20 > tx_checksum set tunnel none 0 >=20 > tx_checksum set ip hw 0 >=20 > So for such case we should set tx_tunnel to 'none'. >=20 > 2> add "tx_checksum set outer-ip (hw|sw) (port-id)" command >=20 > The command is used to set/clear outer IP flag that is used to tell the N= IC that application want hardware offload for outer layer. >=20 > 3> remove the 'vxlan' option from the "tx_checksum set (ip|udp|tcp|sctp|= vxlan) (hw|sw) (port-id)" command >=20 > The command is used to set IP, UDP, TCP and SCTP TX checksum flag. In the= case of tunneling packet, the IP, UDP, TCP and SCTP flags > always concern inner layer. >=20 > Moreover, replace the TESTPMD_TX_OFFLOAD_VXLAN_CKSUM flag with TESTPMD_TX= _OFFLOAD_TUNNEL_CKSUM flag and add the > TESTPMD_TX_OFFLOAD_OUTER_IP_CKSUM and TESTPMD_TX_OFFLOAD_NON_TUNNEL_CKSUM= flag in test-pmd application. >=20 > v2 change: > redefine the 'none' behaviour for "tx_checksum set tunnel (hw|sw|non= e) (port-id)" command. >=20 > Jijiang Liu (3): > add outer IP offload capability in librte_ether. > add outer IP checksum capability in i40e PMD > testpmd command lines of the tx_checksum and csum forwarding rework >=20 > app/test-pmd/cmdline.c | 201 +++++++++++++++++++++++++++++++= ++++-- > app/test-pmd/csumonly.c | 35 ++++--- > app/test-pmd/testpmd.h | 6 +- > lib/librte_ether/rte_ethdev.h | 1 + > lib/librte_pmd_i40e/i40e_ethdev.c | 3 +- > 5 files changed, 218 insertions(+), 28 deletions(-) >=20 Acked-by: Konstantin Ananyev > -- > 1.7.7.6