From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 618137EB0 for ; Mon, 15 Dec 2014 17:41:47 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 15 Dec 2014 08:33:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,580,1413270000"; d="scan'208";a="637819513" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga001.fm.intel.com with ESMTP; 15 Dec 2014 08:33:48 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.144]) by IRSMSX107.ger.corp.intel.com ([169.254.10.190]) with mapi id 14.03.0195.001; Mon, 15 Dec 2014 16:33:48 +0000 From: "Ananyev, Konstantin" To: Neil Horman Thread-Topic: [dpdk-dev] [PATCH 10/17] librte_acl: add AVX2 as new rte_acl_classify() method Thread-Index: AQHQGIBe6R2bzzgwb0yDNvzVCW5u5ZyQ0+9g Date: Mon, 15 Dec 2014 16:33:47 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213C0D9C@IRSMSX105.ger.corp.intel.com> References: <1418580659-12595-1-git-send-email-konstantin.ananyev@intel.com> <1418580659-12595-11-git-send-email-konstantin.ananyev@intel.com> <20141215160009.GC3803@hmsreliant.think-freely.org> In-Reply-To: <20141215160009.GC3803@hmsreliant.think-freely.org> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 10/17] librte_acl: add AVX2 as new rte_acl_classify() method X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Dec 2014 16:41:48 -0000 Hi Neil, > -----Original Message----- > From: Neil Horman [mailto:nhorman@tuxdriver.com] > Sent: Monday, December 15, 2014 4:00 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 10/17] librte_acl: add AVX2 as new rte_acl= _classify() method >=20 > On Sun, Dec 14, 2014 at 06:10:52PM +0000, Konstantin Ananyev wrote: > > Introduce new classify() method that uses AVX2 instructions. > > From my measurements: > > On HSW boards when processing >=3D 16 packets per call, > > AVX2 method outperforms it's SSE counterpart by 10-25%, > > (depending on the ruleset). > > At runtime, this method is selected as default one on HW that supports = AVX2. > > > > Signed-off-by: Konstantin Ananyev > > --- > > lib/librte_acl/Makefile | 9 + > > lib/librte_acl/acl.h | 4 + > > lib/librte_acl/acl_run.h | 2 +- > > lib/librte_acl/acl_run_avx2.c | 58 +++++ > > lib/librte_acl/acl_run_avx2.h | 305 ++++++++++++++++++++++++ > > lib/librte_acl/acl_run_sse.c | 537 +---------------------------------= -------- > > lib/librte_acl/acl_run_sse.h | 533 ++++++++++++++++++++++++++++++++++= +++++++ > > lib/librte_acl/rte_acl.c | 5 +- > > lib/librte_acl/rte_acl.h | 2 + > > 9 files changed, 917 insertions(+), 538 deletions(-) > > create mode 100644 lib/librte_acl/acl_run_avx2.c > > create mode 100644 lib/librte_acl/acl_run_avx2.h > > create mode 100644 lib/librte_acl/acl_run_sse.h > > > > diff --git a/lib/librte_acl/Makefile b/lib/librte_acl/Makefile > > index 65e566d..223ec31 100644 > > --- a/lib/librte_acl/Makefile > > +++ b/lib/librte_acl/Makefile > > @@ -45,8 +45,17 @@ SRCS-$(CONFIG_RTE_LIBRTE_ACL) +=3D acl_bld.c > > SRCS-$(CONFIG_RTE_LIBRTE_ACL) +=3D acl_gen.c > > SRCS-$(CONFIG_RTE_LIBRTE_ACL) +=3D acl_run_scalar.c > > SRCS-$(CONFIG_RTE_LIBRTE_ACL) +=3D acl_run_sse.c > > +SRCS-$(CONFIG_RTE_LIBRTE_ACL) +=3D acl_run_avx2.c > > > > CFLAGS_acl_run_sse.o +=3D -msse4.1 > > +ifeq ($(CC), icc) > > +CFLAGS_acl_run_avx2.o +=3D -march=3Dcore-avx2 > > +else ifneq ($(shell \ > > +test $(GCC_MAJOR_VERSION) -le 4 -a $(GCC_MINOR_VERSION) -le 6 && echo = 1), 1) > > +CFLAGS_acl_run_avx2.o +=3D -mavx2 > > +else > > +CFLAGS_acl_run_avx2.o +=3D -msse4.1 > > +endif > > > This seems broken. You've unilaterally included acl_run_avx2.c in the bu= ild > list above, but only enable -mavx2 if the compiler is at least gcc 4.6. Actually 4.7 (before that version, as I know, gcc doesn't support avx2)=20 > Unless > you want to make gcc 4.6 a requirement for building, I believe DPDK is required to be buildable by gcc 4.6 As I remember, we have to support it all way down to gcc 4.3. > you need to also exclude > the file above from the build list. That means that for gcc 4.6 and below rte_acl_classify_avx2() would not be= defined. And then at runtime, I have to check for that somehow and (re)populate clas= sify_fns[].=20 Doesn't seems like a good way to me. Instead, I prefer to always build acl_run_avx2.c, but for old compilers that don't support AVX2 - rte_acl_classify_avx2() would simply be identical to rte_acl_classify_sse()= .=20 > That in turn I think allows you to remove a > bunch of the ifdeffing that you've done in some of the avx2 specific file= s. Actually there are not many of them. One in acl_run_avx2.h and another in acl_run_avx2.c. Konstantin >=20 > Neil