From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 3977158F7 for ; Fri, 16 Jan 2015 00:55:10 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 15 Jan 2015 15:55:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,407,1418112000"; d="scan'208";a="670731719" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga002.jf.intel.com with ESMTP; 15 Jan 2015 15:54:53 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.195]) by IRSMSX107.ger.corp.intel.com ([169.254.10.190]) with mapi id 14.03.0195.001; Thu, 15 Jan 2015 23:54:52 +0000 From: "Ananyev, Konstantin" To: Ravi Kerur , Thomas Monjalon Thread-Topic: [dpdk-dev] Q on Support for I217 and I218 Intel chipsets. Thread-Index: AQHQKHYtq2//YAz5eE2s33NUueGa/JyxOdCAgACBywCABga8AIAIGsEAgAHXQYCAADTuwA== Date: Thu, 15 Jan 2015 23:54:52 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213D5104@irsmsx105.ger.corp.intel.com> References: <3180122.JKDOmAPjoA@xps13> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] Q on Support for I217 and I218 Intel chipsets. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jan 2015 23:55:14 -0000 Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ravi Kerur > Sent: Thursday, January 15, 2015 8:34 PM > To: Thomas Monjalon > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] Q on Support for I217 and I218 Intel chipsets. >=20 > On Wed, Jan 14, 2015 at 8:27 AM, Thomas Monjalon > wrote: >=20 > > 2015-01-09 04:41, Ravi Kerur: > > > Thomas, > > > > > > Please let me know how I can move forward on this. If i confine chang= es > > in > > > e1000/ directory to e1000_osdep.h file only and the rest in PMD will = that > > > work? The reason I ask is because of following comment in README fil= e. > > > > > > ... > > > Few changes to the original FreeBSD sources were made to: > > > - Adopt it for PMD usage mode: > > > e1000_osdep.c > > > e1000_osdep.h > > > ... Yes, if needed you can modify these files. In fact, these files are the only 2 that are allowed to be modified inside = e1000 sub-directory. As I understand you plan to implement E1000_READ_FLASH_REG and E1000_WRITE= _FLASH_REG macros properly, correct? Konstantin > > > > This is an Intel driver so you should ask to the responsible of this co= de > > at Intel. > > The problem is that there is not really an identified responsible for t= his > > driver. > > > > The rule is to not change the base driver, even osdep files. > > But it would be better to have an exception here. > > > > > > PS: please avoid top-posting. > > >=20 > Please let me know who is the contact person from Intel so I can add > him/her to "To" list when I send the patch or Should I contact Jim St Leg= er > and ask him about this? >=20 > Thanks. >=20 > > > > > On Mon, Jan 5, 2015 at 8:40 AM, Ravi Kerur wrote: > > > > > > > Inline > > > > > > > > On Mon, Jan 5, 2015 at 12:55 AM, Thomas Monjalon < > > > > thomas.monjalon@6wind.com> wrote: > > > > > > > >> 2015-01-04 15:28, Ravi Kerur: > > > >> > We have a Gigabyte H97N motherboard which has I217 Intel chipset > > which > > > >> uses > > > >> > e100e drivers. I looked into lib/librte_pmd_e1000 directory and = I > > do see > > > >> > that e1000e code is integrated but missing some support for > > read/write > > > >> from > > > >> > flash_address and other minor things. I have made changes shown > > below > > > >> and > > > >> > have done some testing with testpmd utility and now have followi= ng > > > >> questions > > > >> > > > > >> > 1. What amount of testing is required to qualify patch as > > successfully > > > >> > tested on new chipsets > > > >> > > > >> There is no good answer to this question. Generally, you must be s= ure > > that > > > >> you don't break anything. > > > >> So you must test the code paths you have changed. > > > >> > > > > > > > > yes I have done testing on Ubuntu for I217 using testpmd. > > > > > > > >> > > > >> > 2. FreeBSD testing, currently we have Ubuntu 14.04 installed on > > existing > > > >> > H97N motherboard and testing is done solely on Linux. We plan to= get > > > >> > another motherboard which will have I218 chipset and still decid= ing > > > >> whether > > > >> > to go with FreeBSD or Ubuntu. So the question I have is what amo= unt > > of > > > >> > testing should be done on FreeBSD? I don't think > > > >> setup.sh/dpdk_nic_bind.py > > > >> > works on FreeBSD yet hence the question on testing. > > > >> > > > >> FreeBSD testing is required when patching common EAL, scripts or > > > >> makefiles. > > > >> > > > >> > > lib/librte_pmd_e1000/e1000/e1000_api.c | 21 > > > >> +++++++++++++++++++++ > > > >> > > lib/librte_pmd_e1000/e1000/e1000_api.h | 1 + > > > >> > > lib/librte_pmd_e1000/e1000/e1000_osdep.h | 24 > > > >> +++++++++++++++++++----- > > > >> > > > >> These files are part of the base driver. > > > >> The rule is to not patch them and try to do the changes in PMD onl= y. > > > >> There can be exceptions if an Intel maintainer acknowledges it. > > > >> > > > > > > > > Changes in these files are modifying existing macros > > > > > > > > E1000_READ_FLASH_REG, > > > > E1000_WRITE_FLASH_REG > > > > ... > > > > > > > > If it is not recommended to modify these files, should I move macro= s > > into > > > > some PMD file? > > > > > > > > Thanks. > > > >