From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 468645A84 for ; Fri, 16 Jan 2015 13:01:38 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 16 Jan 2015 04:01:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,410,1418112000"; d="scan'208";a="671020266" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga002.jf.intel.com with ESMTP; 16 Jan 2015 04:01:36 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.81]) by IRSMSX106.ger.corp.intel.com ([169.254.8.94]) with mapi id 14.03.0195.001; Fri, 16 Jan 2015 12:01:35 +0000 From: "Ananyev, Konstantin" To: "Richardson, Bruce" Thread-Topic: [dpdk-dev] Q on Support for I217 and I218 Intel chipsets. Thread-Index: AQHQKHYtq2//YAz5eE2s33NUueGa/JyxOdCAgACBywCABga8AIAIGsEAgAHXQYCAADTuwIAAuvaAgAADe2CAAAdZAIAACCLg Date: Fri, 16 Jan 2015 12:01:34 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213DB45B@irsmsx105.ger.corp.intel.com> References: <3180122.JKDOmAPjoA@xps13> <2601191342CEEE43887BDE71AB977258213D5104@irsmsx105.ger.corp.intel.com> <20150116105255.GA10516@bricha3-MOBL3> <2601191342CEEE43887BDE71AB977258213DA3B9@irsmsx105.ger.corp.intel.com> <20150116113140.GD10516@bricha3-MOBL3> In-Reply-To: <20150116113140.GD10516@bricha3-MOBL3> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] Q on Support for I217 and I218 Intel chipsets. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jan 2015 12:01:38 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Friday, January 16, 2015 11:32 AM > To: Ananyev, Konstantin > Cc: Ravi Kerur; Thomas Monjalon; dev@dpdk.org > Subject: Re: [dpdk-dev] Q on Support for I217 and I218 Intel chipsets. >=20 > On Fri, Jan 16, 2015 at 11:08:46AM +0000, Ananyev, Konstantin wrote: > > > > > > > -----Original Message----- > > > From: Richardson, Bruce > > > Sent: Friday, January 16, 2015 10:53 AM > > > To: Ananyev, Konstantin > > > Cc: Ravi Kerur; Thomas Monjalon; dev@dpdk.org > > > Subject: Re: [dpdk-dev] Q on Support for I217 and I218 Intel chipsets= . > > > > > > On Thu, Jan 15, 2015 at 11:54:52PM +0000, Ananyev, Konstantin wrote: > > > > Hi, > > > > > > > > > -----Original Message----- > > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ravi Kerur > > > > > Sent: Thursday, January 15, 2015 8:34 PM > > > > > To: Thomas Monjalon > > > > > Cc: dev@dpdk.org > > > > > Subject: Re: [dpdk-dev] Q on Support for I217 and I218 Intel chip= sets. > > > > > > > > > > On Wed, Jan 14, 2015 at 8:27 AM, Thomas Monjalon > > > > > wrote: > > > > > > > > > > > 2015-01-09 04:41, Ravi Kerur: > > > > > > > Thomas, > > > > > > > > > > > > > > Please let me know how I can move forward on this. If i confi= ne changes > > > > > > in > > > > > > > e1000/ directory to e1000_osdep.h file only and the rest in P= MD will that > > > > > > > work? The reason I ask is because of following comment in RE= ADME file. > > > > > > > > > > > > > > ... > > > > > > > Few changes to the original FreeBSD sources were made to: > > > > > > > - Adopt it for PMD usage mode: > > > > > > > e1000_osdep.c > > > > > > > e1000_osdep.h > > > > > > > ... > > > > > > > > Yes, if needed you can modify these files. > > > > In fact, these files are the only 2 that are allowed to be modified= inside e1000 sub-directory. > > > > As I understand you plan to implement E1000_READ_FLASH_REG and E10= 00_WRITE_FLASH_REG > > > > macros properly, correct? > > > > Konstantin > > > > > > > > > > As a cleanup we should really look to move these two files out of the= e1000 > > > subdirectory (and similarly for the ixgbe versions etc.), so as to gi= ve a cleaner > > > and more manageable separation between what can be edited or not. > > > > It was always like that for all Intel PMDs we have: > > > > $ find lib/ -name '*_osdep.*' | grep -v acl > > lib/librte_pmd_vmxnet3/vmxnet3/vmxnet3_osdep.h > > lib/librte_pmd_ixgbe/ixgbe/ixgbe_osdep.h > > lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_osdep.h > > lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h > > lib/librte_pmd_i40e/i40e/i40e_osdep.h > > lib/librte_pmd_e1000/e1000/e1000_osdep.c > > lib/librte_pmd_e1000/e1000/e1000_osdep.h > > > > As I understand ND has it's own version of _osdep.* for each O= S they support. > > We obviously modify it to fit DPDK purposes. > > > > Konstantin > > > > > > > > /Bruce >=20 > Yep. Doesn't mean we haven't put it in the wrong place though! :-) We just don't move it at all :) It is at the same place where ND puts it, we just modify the contents. >>From my point - current location is perfectly ok. Konstantin >=20 > /Bruce