From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id C4C995A6F
 for <dev@dpdk.org>; Tue, 20 Jan 2015 11:56:24 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga102.jf.intel.com with ESMTP; 20 Jan 2015 02:53:27 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.09,433,1418112000"; d="scan'208";a="514776152"
Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25])
 by orsmga003.jf.intel.com with ESMTP; 20 Jan 2015 02:49:46 -0800
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.81]) by
 irsmsx110.ger.corp.intel.com ([169.254.15.8]) with mapi id 14.03.0195.001;
 Tue, 20 Jan 2015 10:56:22 +0000
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v2 11/17] librte_acl: add AVX2 as new
 rte_acl_classify() method
Thread-Index: AQHQNAygCQDFtQBtyUORaqyoQ5NUCZzIy/sQ
Date: Tue, 20 Jan 2015 10:56:22 +0000
Message-ID: <2601191342CEEE43887BDE71AB977258213DE0A3@irsmsx105.ger.corp.intel.com>
References: <1421090181-17150-1-git-send-email-konstantin.ananyev@intel.com>
 <1421090181-17150-12-git-send-email-konstantin.ananyev@intel.com>
 <1576198.aXfb5MeZ7p@xps13>
In-Reply-To: <1576198.aXfb5MeZ7p@xps13>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 11/17] librte_acl: add AVX2 as new
 rte_acl_classify() method
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Jan 2015 10:56:25 -0000



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, January 19, 2015 5:23 PM
> To: Ananyev, Konstantin
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 11/17] librte_acl: add AVX2 as new rte_=
acl_classify() method
>=20
> 2015-01-12 19:16, Konstantin Ananyev:
> > +/*
> > + * Select highest avaialbe classify method as default one.
>=20
> Typo here.
> Actually, I've seen few typos when browsing your big patchset
> but I don't remember exactly where.
> Maybe that a tool like codespell could help.
>=20
> [...]
>=20
> > +	else if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_SSE4_1))
> > +#else
> >  	if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_SSE4_1))
> > +#endif
>=20
> Minor nit, it could be
> +	else
> +#endif
>  	if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_SSE4_1))

I made it deliberately.
>>From my point, It seems more clear and easy to read with 'else if' at one l=
ine.
Konstantin


>=20
> --
> Thomas