DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Olivier MATZ <olivier.matz@6wind.com>,
	"Liu, Jijiang" <jijiang.liu@intel.com>,
	"Zhang, Helin" <helin.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum forwarding engine
Date: Mon, 26 Jan 2015 14:15:12 +0000	[thread overview]
Message-ID: <2601191342CEEE43887BDE71AB977258213DF90B@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <54C64A10.2010906@6wind.com>


Hi Olivier,

> -----Original Message-----
> From: Olivier MATZ [mailto:olivier.matz@6wind.com]
> Sent: Monday, January 26, 2015 2:07 PM
> To: Liu, Jijiang; Ananyev, Konstantin; Zhang, Helin
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum forwarding engine
> 
> Hi,
> 
> On 01/26/2015 07:02 AM, Liu, Jijiang wrote:
> >> I tried to repeat Olivier test-cases on my box.
> >> Though, I didn't use test-pmd cusmonly and  i40ePMD logic, but filled TCD and
> >> TDD mostly from hardcoded values.
> >> That's  what I got:
> >>
> >> 4 input packets:
> >> a) ETHER/IPv4/UDP/VXLAN/ETHER/IPV4/TCP
> >> b) ETHER/IPv4/GRE/ETHER/IPV4/TCP
> >> c) ETHER/IPv4/GRE/IPV4/TCP
> >> d) ETHER/IPv4/IPV4/TCP
> >>
> >> 1/ L4TUNT==1(I40E_TXD_CTX_UDP_TUNNELING):
> >> a),b): all checksums ok
> >> c),d): not transmitted by HW.
> >>
> >> 2/ L4TUNT==2(I40E_TXD_CTX_GRE_TUNNELING):
> >> a) b),c): all checksums ok
> >> d): not transmitted by HW.
> >>
> >> 3/ L4TUNT==0(UNKNOWN):
> >> a),b),c),d): all checksums ok
> >>
> >> So yes, it seems that L4TUNT==0 works perfectly ok for all cases, as long as
> >> L4TUNLEN and other TCD values are setup properly.
> >> Which makes me think, that  probably we can do what you suggested: just use
> >> L4TUNT=0 for all cases.
> >> Though as Jijiang said, we waiting for confirmation from FVL guys, that there are
> >> no hidden implications with that approach.
> >
> > Yes, the L4TUNT=0 is ok  for all cases.
> 
> Great! Thanks for testing on your side too.
> 
> > But we still need to get confirmation from FVL guys, probably there are some issues in HW/FW.
> > I and Helin will confirm this with FVL guys ASAP.
> 
> OK, thank you.
> 
> >> Another thing - IPIP seems to work ok by HW.
> >> There is something wrong on our (PMD/test-pmd) side.
> >> I think at least we have to remove the following check:
> >> if (!l2_len) {
> >>                 PMD_DRV_LOG(DEBUG, "L2 length set to 0");
> >>                 return;
> >>         }
> >> in i40e_txd_enable_checksum().
> >
> > Yes, for IPIP, the check should be removed.
> 
> Yes, I think these lines should be removed for 2 reasons:
> - it may be the cause of ipip tunnel not working
> - we shouldn't do these kind of tests in dataplane. I think we have to
>   suppose that the data passed to the PMD is valid.
> 
> I'll redo the test with ipip tomorrow with this fix and let you
> know the result. If it works, I'll add this in the next version
> of the patch.

While you are on this, can I suggest you'll add debug logging for TCD and TDD we are writing to the TX ring?
Something like that:

+                       PMD_TX_LOG(DEBUG, "mbuf: %p, TCD[%u]:\n"
+                               "tunneling_params: %#x;\n"
+                               "l2tag2: %#hx;\n"
+                               "rsvd: %#hx;\n"
+                               "type_cmd_tso_mss: %#lx;\n",
+                               tx_pkt, tx_id,
+                               ctx_txd->tunneling_params,
+                               ctx_txd->l2tag2,
+                               ctx_txd->rsvd,
+                               ctx_txd->type_cmd_tso_mss);

And same for TDD. 
It  helped me a lot to figure out what is going on, when I did my tests.
Probably would be useful for other people too.

Konstantin

> 
> Regards,
> Olivier

  reply	other threads:[~2015-01-26 14:17 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-10  1:03 Jijiang Liu
2014-12-10  1:03 ` [dpdk-dev] [PATCH v3 1/3] librte_ether:add outer IP offload capability flag Jijiang Liu
2014-12-11 10:33   ` Olivier MATZ
2014-12-10  1:03 ` [dpdk-dev] [PATCH v3 2/3] i40e:support outer IPv4 checksum capability Jijiang Liu
2014-12-11 10:34   ` Olivier MATZ
2014-12-10  1:03 ` [dpdk-dev] [PATCH v3 3/3] app/testpmd:change tx_checksum command and csum forwarding engine Jijiang Liu
2014-12-11 10:52   ` Olivier MATZ
2014-12-12  4:06     ` Liu, Jijiang
2014-12-11 10:17 ` [dpdk-dev] [PATCH v3 0/3] enhance TX checksum " Olivier MATZ
2014-12-12  3:48   ` Liu, Jijiang
2014-12-12 16:33     ` Olivier MATZ
2015-01-07  2:03       ` Liu, Jijiang
2015-01-07  9:59         ` Ananyev, Konstantin
2015-01-07 11:39           ` Liu, Jijiang
2015-01-07 12:07             ` Ananyev, Konstantin
2015-01-08  8:51               ` Liu, Jijiang
2015-01-08 10:54                 ` Ananyev, Konstantin
2015-01-09 10:45                   ` Olivier MATZ
2015-01-12  3:41                     ` Liu, Jijiang
2015-01-12 11:43                       ` Olivier MATZ
2015-01-13  3:04                         ` Liu, Jijiang
2015-01-13  9:55                           ` Olivier MATZ
2015-01-14  3:01                             ` Liu, Jijiang
2015-01-15 13:31                               ` Ananyev, Konstantin
2015-01-16 17:27                                 ` Olivier MATZ
2015-01-19 13:04                                   ` Ananyev, Konstantin
2015-01-19 14:38                                     ` Olivier MATZ
2015-01-20  1:12                                       ` Ananyev, Konstantin
2015-01-20 12:39                                         ` Olivier MATZ
2015-01-20 15:18                                           ` Thomas Monjalon
2015-01-20 17:10                                             ` Stephen Hemminger
2015-01-20 17:23                                           ` Ananyev, Konstantin
2015-01-20 18:15                                             ` Olivier MATZ
2015-01-21  3:12                                               ` Liu, Jijiang
2015-01-21 15:25                                                 ` Olivier MATZ
2015-01-21 16:28                                                   ` Ananyev, Konstantin
2015-01-21 17:13                                                     ` Olivier MATZ
2015-01-26  4:13                                                   ` Ananyev, Konstantin
2015-01-26  6:02                                                     ` Liu, Jijiang
2015-01-26 14:07                                                       ` Olivier MATZ
2015-01-26 14:15                                                         ` Ananyev, Konstantin [this message]
2015-01-27  8:34                                                           ` Olivier MATZ
2015-01-27 15:26                                                             ` Ananyev, Konstantin
2015-01-21 19:44                                                 ` Stephen Hemminger
2015-01-22  1:40                                                   ` Liu, Jijiang
2015-01-21  8:01                                               ` Liu, Jijiang
2015-01-21  9:10                                                 ` Olivier MATZ
2015-01-21 11:52                                                   ` Ananyev, Konstantin
2015-01-07 13:06 ` Qiu, Michael

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2601191342CEEE43887BDE71AB977258213DF90B@irsmsx105.ger.corp.intel.com \
    --to=konstantin.ananyev@intel.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=jijiang.liu@intel.com \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).