DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Markovic, Stevan" <smarkovi@akamai.com>,
	"yuzhichang_scl@hotmail.com" <yuzhichang_scl@hotmail.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] ACL lookup doesn't work for some schemes
Date: Mon, 16 Feb 2015 16:08:52 +0000	[thread overview]
Message-ID: <2601191342CEEE43887BDE71AB977258213EDC8B@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <D1077203.3B62D%smarkovi@akamai.com>



> -----Original Message-----
> From: Markovic, Stevan [mailto:smarkovi@akamai.com]
> Sent: Monday, February 16, 2015 3:22 PM
> To: Ananyev, Konstantin; yuzhichang_scl@hotmail.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] ACL lookup doesn't work for some schemes
> 
> Hi,
> 
> 
> On 2/16/15, 4:56 AM, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
> wrote:
> 
> >
> >Yes, right now, libtre_acl to work correctly first field has to be 1B
> >long and all subsequent grouped into sets of 4 consecutive bytes.
> >I thought we have it documented into our PG, ACL section:
> >http://dpdk.org/doc/guides/prog_guide/packet_classif_access_ctrl.html
> >Though re-reading it again:
> >"For performance reasons, the inner loop of the search function is
> >unrolled to process four input bytes at a time. This requires the input
> >to be grouped into sets of 4 consecutive bytes. The loop processes the
> >first input byte as part of the setup and then subsequent bytes must be
> >in groups of 4 consecutive bytes."
> >It probably not very clear and need to be explained in more details.
> >Will update the doc.
> >
> >Konstantin
> >
> 
> While improving API documentation would be great, enforcing these
> constraints on user defined fields in rte_acl_build(?) also (return an
> error if constraints are not met) would be even better.
> 
> Stevan

Good point. Will try to add some extra checks  to rte_acl_build().
If time permits - for 2.0 timeframe, if not then for 2.1.  
Konstantin

      parent reply	other threads:[~2015-02-16 16:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-15  9:18 志昌余
2015-02-15  9:23 ` 志昌余
2015-02-15  9:29   ` 志昌余
2015-02-16  9:56 ` Ananyev, Konstantin
2015-02-16 15:37   ` Stevan Markovic
     [not found]   ` <D1077203.3B62D%smarkovi@akamai.com>
2015-02-16 16:08     ` Ananyev, Konstantin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2601191342CEEE43887BDE71AB977258213EDC8B@irsmsx105.ger.corp.intel.com \
    --to=konstantin.ananyev@intel.com \
    --cc=dev@dpdk.org \
    --cc=smarkovi@akamai.com \
    --cc=yuzhichang_scl@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).