From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 31B36B5FE for ; Mon, 16 Feb 2015 17:08:57 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 16 Feb 2015 08:01:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,588,1418112000"; d="scan'208";a="652858395" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga001.jf.intel.com with ESMTP; 16 Feb 2015 08:08:54 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.117]) by IRSMSX103.ger.corp.intel.com ([169.254.3.247]) with mapi id 14.03.0195.001; Mon, 16 Feb 2015 16:08:53 +0000 From: "Ananyev, Konstantin" To: "Markovic, Stevan" , "yuzhichang_scl@hotmail.com" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] ACL lookup doesn't work for some schemes Thread-Index: AQHQSQB5HnFgGDtmC0yhuvSeRcsoDJzzCdcwgABc44CAAAw9QA== Date: Mon, 16 Feb 2015 16:08:52 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213EDC8B@irsmsx105.ger.corp.intel.com> References: <2601191342CEEE43887BDE71AB977258213EC8FE@irsmsx105.ger.corp.intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] ACL lookup doesn't work for some schemes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 16:08:57 -0000 > -----Original Message----- > From: Markovic, Stevan [mailto:smarkovi@akamai.com] > Sent: Monday, February 16, 2015 3:22 PM > To: Ananyev, Konstantin; yuzhichang_scl@hotmail.com; dev@dpdk.org > Subject: Re: [dpdk-dev] ACL lookup doesn't work for some schemes >=20 > Hi, >=20 >=20 > On 2/16/15, 4:56 AM, "Ananyev, Konstantin" > wrote: >=20 > > > >Yes, right now, libtre_acl to work correctly first field has to be 1B > >long and all subsequent grouped into sets of 4 consecutive bytes. > >I thought we have it documented into our PG, ACL section: > >http://dpdk.org/doc/guides/prog_guide/packet_classif_access_ctrl.html > >Though re-reading it again: > >"For performance reasons, the inner loop of the search function is > >unrolled to process four input bytes at a time. This requires the input > >to be grouped into sets of 4 consecutive bytes. The loop processes the > >first input byte as part of the setup and then subsequent bytes must be > >in groups of 4 consecutive bytes." > >It probably not very clear and need to be explained in more details. > >Will update the doc. > > > >Konstantin > > >=20 > While improving API documentation would be great, enforcing these > constraints on user defined fields in rte_acl_build(?) also (return an > error if constraints are not met) would be even better. >=20 > Stevan Good point. Will try to add some extra checks to rte_acl_build(). If time permits - for 2.0 timeframe, if not then for 2.1. =20 Konstantin