DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Panu Matilainen <pmatilai@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] i40e: fix build with gcc 5
Date: Thu, 19 Feb 2015 11:05:24 +0000	[thread overview]
Message-ID: <2601191342CEEE43887BDE71AB977258213F0C28@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <442c1d71592455d2f3c8df4cc944cc48c1092fc6.1424341431.git.pmatilai@redhat.com>



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen
> Sent: Thursday, February 19, 2015 10:25 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] i40e: fix build with gcc 5
> 
> Eliminate embiguity in the condition which trips up a "logical not
> is only applied to the left..." warning from gcc 5, causing build
> failure with -Werror.
> 
> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
> ---
>  lib/librte_pmd_i40e/i40e_rxtx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_pmd_i40e/i40e_rxtx.c b/lib/librte_pmd_i40e/i40e_rxtx.c
> index c9f1026..ede5405 100644
> --- a/lib/librte_pmd_i40e/i40e_rxtx.c
> +++ b/lib/librte_pmd_i40e/i40e_rxtx.c
> @@ -613,7 +613,7 @@ check_rx_burst_bulk_alloc_preconditions(__rte_unused struct i40e_rx_queue *rxq)
>  			     "rxq->nb_rx_desc=%d",
>  			     rxq->rx_free_thresh, rxq->nb_rx_desc);
>  		ret = -EINVAL;
> -	} else if (!(rxq->nb_rx_desc % rxq->rx_free_thresh) == 0) {
> +	} else if (!(rxq->nb_rx_desc % rxq->rx_free_thresh == 0)) {

Why just not:
else if (rxq->nb_rx_desc % rxq->rx_free_thresh != 0)
?

>  		PMD_INIT_LOG(DEBUG, "Rx Burst Bulk Alloc Preconditions: "
>  			     "rxq->nb_rx_desc=%d, "
>  			     "rxq->rx_free_thresh=%d",
> --
> 2.1.0

  reply	other threads:[~2015-02-19 11:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-19 10:25 [dpdk-dev] [PATCH] ixgbe: " Panu Matilainen
2015-02-19 10:25 ` [dpdk-dev] [PATCH] i40e: " Panu Matilainen
2015-02-19 11:05   ` Ananyev, Konstantin [this message]
2015-02-19 11:09     ` Panu Matilainen
2015-02-19 11:21   ` [dpdk-dev] [PATCH v2] " Panu Matilainen
2015-02-19 11:41     ` Ananyev, Konstantin
2015-02-20 14:11       ` Thomas Monjalon
2015-02-19 12:02 ` [dpdk-dev] [PATCH] ixgbe: " Ananyev, Konstantin
2015-02-19 12:37   ` Panu Matilainen
2015-02-19 13:07   ` Neil Horman
2015-02-24 13:13 ` [dpdk-dev] [PATCH v2] " Panu Matilainen
2015-02-24 13:45   ` Ananyev, Konstantin
2015-02-25 15:26     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2601191342CEEE43887BDE71AB977258213F0C28@irsmsx105.ger.corp.intel.com \
    --to=konstantin.ananyev@intel.com \
    --cc=dev@dpdk.org \
    --cc=pmatilai@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).