From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 40311B533 for ; Thu, 19 Feb 2015 12:05:48 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 19 Feb 2015 03:00:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,512,1418112000"; d="scan'208";a="687833166" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by orsmga002.jf.intel.com with ESMTP; 19 Feb 2015 03:05:26 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.117]) by IRSMSX108.ger.corp.intel.com ([169.254.11.218]) with mapi id 14.03.0195.001; Thu, 19 Feb 2015 11:05:25 +0000 From: "Ananyev, Konstantin" To: Panu Matilainen , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] i40e: fix build with gcc 5 Thread-Index: AQHQTC6s1xX5+VUpRUCgxsCYd+yfqpz3zz9Q Date: Thu, 19 Feb 2015 11:05:24 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213F0C28@irsmsx105.ger.corp.intel.com> References: <442c1d71592455d2f3c8df4cc944cc48c1092fc6.1424341431.git.pmatilai@redhat.com> In-Reply-To: <442c1d71592455d2f3c8df4cc944cc48c1092fc6.1424341431.git.pmatilai@redhat.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] i40e: fix build with gcc 5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 11:05:48 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen > Sent: Thursday, February 19, 2015 10:25 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] i40e: fix build with gcc 5 >=20 > Eliminate embiguity in the condition which trips up a "logical not > is only applied to the left..." warning from gcc 5, causing build > failure with -Werror. >=20 > Signed-off-by: Panu Matilainen > --- > lib/librte_pmd_i40e/i40e_rxtx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_pmd_i40e/i40e_rxtx.c b/lib/librte_pmd_i40e/i40e_r= xtx.c > index c9f1026..ede5405 100644 > --- a/lib/librte_pmd_i40e/i40e_rxtx.c > +++ b/lib/librte_pmd_i40e/i40e_rxtx.c > @@ -613,7 +613,7 @@ check_rx_burst_bulk_alloc_preconditions(__rte_unused = struct i40e_rx_queue *rxq) > "rxq->nb_rx_desc=3D%d", > rxq->rx_free_thresh, rxq->nb_rx_desc); > ret =3D -EINVAL; > - } else if (!(rxq->nb_rx_desc % rxq->rx_free_thresh) =3D=3D 0) { > + } else if (!(rxq->nb_rx_desc % rxq->rx_free_thresh =3D=3D 0)) { Why just not: else if (rxq->nb_rx_desc % rxq->rx_free_thresh !=3D 0) ? > PMD_INIT_LOG(DEBUG, "Rx Burst Bulk Alloc Preconditions: " > "rxq->nb_rx_desc=3D%d, " > "rxq->rx_free_thresh=3D%d", > -- > 2.1.0