From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6E9371F7 for ; Thu, 19 Feb 2015 13:02:10 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 19 Feb 2015 04:02:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,512,1418112000"; d="scan'208";a="680303460" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga002.fm.intel.com with ESMTP; 19 Feb 2015 04:02:07 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.117]) by IRSMSX101.ger.corp.intel.com ([163.33.3.153]) with mapi id 14.03.0195.001; Thu, 19 Feb 2015 12:02:07 +0000 From: "Ananyev, Konstantin" To: Panu Matilainen , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] ixgbe: fix build with gcc 5 Thread-Index: AQHQTC5s3SKbE5RRZEOI1rB+mVuA65z3z/dw Date: Thu, 19 Feb 2015 12:02:06 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213F0CA8@irsmsx105.ger.corp.intel.com> References: In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix build with gcc 5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 12:02:10 -0000 Hi Panu, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen > Sent: Thursday, February 19, 2015 10:25 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] ixgbe: fix build with gcc 5 >=20 > Add extra parenthesis to remove ambiguity on what we want to compare, > otherwise gcc 5 issues a "logical not is only applied to the left hand > side of comparison" warning which with -Werror fails the build. >=20 > Signed-off-by: Panu Matilainen > --- > lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c b/lib/librte_pmd_i= xgbe/ixgbe/ixgbe_common.c > index 37e5bae..93a6a00 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c > +++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c > @@ -2898,8 +2898,8 @@ STATIC s32 ixgbe_fc_autoneg_fiber(struct ixgbe_hw *= hw) > */ >=20 > linkstat =3D IXGBE_READ_REG(hw, IXGBE_PCS1GLSTA); > - if ((!!(linkstat & IXGBE_PCS1GLSTA_AN_COMPLETE) =3D=3D 0) || > - (!!(linkstat & IXGBE_PCS1GLSTA_AN_TIMED_OUT) =3D=3D 1)) { > + if (((!!(linkstat & IXGBE_PCS1GLSTA_AN_COMPLETE)) =3D=3D 0) || > + ((!!(linkstat & IXGBE_PCS1GLSTA_AN_TIMED_OUT)) =3D=3D 1)) { > ERROR_REPORT1(IXGBE_ERROR_POLLING, > "Auto-Negotiation did not complete or timed out"); > goto out; Unfortunately we are not supposed to change files under ixgbe subfirectory = (except ixgbe_osdep.*). Usually we deal with it just by: If GCC_VERSION... CFLAGS_ixgbe_common.o +=3D -Wno... You can have a look at lib/librte_pmd_ixgbe/Makefile, there are plenty of s= uch things. Konstantin > -- > 2.1.0