From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Panu Matilainen <pmatilai@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix build with gcc 5
Date: Tue, 24 Feb 2015 13:45:58 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB977258213F2123@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <b185ffdaacf91cf99f0d6442e7fcf9a3a736b7fb.1424783608.git.pmatilai@redhat.com>
> -----Original Message-----
> From: Panu Matilainen [mailto:pmatilai@redhat.com]
> Sent: Tuesday, February 24, 2015 1:14 PM
> To: dev@dpdk.org
> Cc: Ananyev, Konstantin
> Subject: [PATCH v2] ixgbe: fix build with gcc 5
>
> gcc 5 supports a new logical-not-parentheses warning which
> ixgbe_common.c triggers, causing build failure with -Werror.
> Since this source must not be modified, silence the warning instead.
>
> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> ---
> lib/librte_pmd_ixgbe/Makefile | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/lib/librte_pmd_ixgbe/Makefile b/lib/librte_pmd_ixgbe/Makefile
> index 43870f7..9a5cd33 100644
> --- a/lib/librte_pmd_ixgbe/Makefile
> +++ b/lib/librte_pmd_ixgbe/Makefile
> @@ -71,6 +71,10 @@ CFLAGS_ixgbe_common.o += -Wno-unused-but-set-variable
> CFLAGS_ixgbe_x550.o += -Wno-unused-but-set-variable -Wno-maybe-uninitialized
> endif
>
> +ifeq ($(shell test $(GCC_VERSION) -ge 50 && echo 1), 1)
> +CFLAGS_ixgbe_common.o += -Wno-logical-not-parentheses
> +endif
> +
> ifeq ($(shell test $(GCC_VERSION) -le 46 && echo 1), 1)
> CFLAGS_ixgbe_x550.o += -Wno-uninitialized
> CFLAGS_ixgbe_phy.o += -Wno-uninitialized
> --
> 2.1.0
next prev parent reply other threads:[~2015-02-24 13:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 10:25 [dpdk-dev] [PATCH] " Panu Matilainen
2015-02-19 10:25 ` [dpdk-dev] [PATCH] i40e: " Panu Matilainen
2015-02-19 11:05 ` Ananyev, Konstantin
2015-02-19 11:09 ` Panu Matilainen
2015-02-19 11:21 ` [dpdk-dev] [PATCH v2] " Panu Matilainen
2015-02-19 11:41 ` Ananyev, Konstantin
2015-02-20 14:11 ` Thomas Monjalon
2015-02-19 12:02 ` [dpdk-dev] [PATCH] ixgbe: " Ananyev, Konstantin
2015-02-19 12:37 ` Panu Matilainen
2015-02-19 13:07 ` Neil Horman
2015-02-24 13:13 ` [dpdk-dev] [PATCH v2] " Panu Matilainen
2015-02-24 13:45 ` Ananyev, Konstantin [this message]
2015-02-25 15:26 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB977258213F2123@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=pmatilai@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).