From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id E6F7EAD85
 for <dev@dpdk.org>; Tue, 24 Feb 2015 14:46:02 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga101.jf.intel.com with ESMTP; 24 Feb 2015 05:46:02 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.09,638,1418112000"; d="scan'208";a="656441740"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
 by orsmga001.jf.intel.com with ESMTP; 24 Feb 2015 05:46:01 -0800
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.117]) by
 IRSMSX104.ger.corp.intel.com ([169.254.5.145]) with mapi id 14.03.0195.001;
 Tue, 24 Feb 2015 13:45:59 +0000
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Panu Matilainen <pmatilai@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH v2] ixgbe: fix build with gcc 5
Thread-Index: AQHQUDPAj04SO9drh023h9pKPTMMl5z/z9KQ
Date: Tue, 24 Feb 2015 13:45:58 +0000
Message-ID: <2601191342CEEE43887BDE71AB977258213F2123@irsmsx105.ger.corp.intel.com>
References: <a90ae275e7fc4bac15fcef89119accdf1821b552.1424341431.git.pmatilai@redhat.com>
 <b185ffdaacf91cf99f0d6442e7fcf9a3a736b7fb.1424783608.git.pmatilai@redhat.com>
In-Reply-To: <b185ffdaacf91cf99f0d6442e7fcf9a3a736b7fb.1424783608.git.pmatilai@redhat.com>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix build with gcc 5
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Feb 2015 13:46:03 -0000



> -----Original Message-----
> From: Panu Matilainen [mailto:pmatilai@redhat.com]
> Sent: Tuesday, February 24, 2015 1:14 PM
> To: dev@dpdk.org
> Cc: Ananyev, Konstantin
> Subject: [PATCH v2] ixgbe: fix build with gcc 5
>=20
> gcc 5 supports a new logical-not-parentheses warning which
> ixgbe_common.c triggers, causing build failure with -Werror.
> Since this source must not be modified, silence the warning instead.
>=20
> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> ---
>  lib/librte_pmd_ixgbe/Makefile | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/lib/librte_pmd_ixgbe/Makefile b/lib/librte_pmd_ixgbe/Makefil=
e
> index 43870f7..9a5cd33 100644
> --- a/lib/librte_pmd_ixgbe/Makefile
> +++ b/lib/librte_pmd_ixgbe/Makefile
> @@ -71,6 +71,10 @@ CFLAGS_ixgbe_common.o +=3D -Wno-unused-but-set-variabl=
e
>  CFLAGS_ixgbe_x550.o +=3D -Wno-unused-but-set-variable -Wno-maybe-uniniti=
alized
>  endif
>=20
> +ifeq ($(shell test $(GCC_VERSION) -ge 50 && echo 1), 1)
> +CFLAGS_ixgbe_common.o +=3D -Wno-logical-not-parentheses
> +endif
> +
>  ifeq ($(shell test $(GCC_VERSION) -le 46 && echo 1), 1)
>  CFLAGS_ixgbe_x550.o +=3D -Wno-uninitialized
>  CFLAGS_ixgbe_phy.o +=3D -Wno-uninitialized
> --
> 2.1.0