From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 1591C2EDA for ; Mon, 9 Mar 2015 12:29:34 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP; 09 Mar 2015 04:29:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,367,1422950400"; d="scan'208";a="538019524" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga003.jf.intel.com with ESMTP; 09 Mar 2015 04:29:05 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.117]) by IRSMSX109.ger.corp.intel.com ([169.254.13.103]) with mapi id 14.03.0195.001; Mon, 9 Mar 2015 11:29:32 +0000 From: "Ananyev, Konstantin" To: "Wodkowski, PawelX" , Vlad Zolotarov , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups Thread-Index: AQHQWlmA9ui88v3CaE+Oi3QRrjwggp0UAdWg Date: Mon, 9 Mar 2015 11:29:31 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213F4B99@irsmsx105.ger.corp.intel.com> References: <1425896433-12452-1-git-send-email-vladz@cloudius-systems.com> <1425896433-12452-2-git-send-email-vladz@cloudius-systems.com> <2601191342CEEE43887BDE71AB977258213F4B37@irsmsx105.ger.corp.intel.com> <54FD7F5A.4090809@intel.com> In-Reply-To: <54FD7F5A.4090809@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2015 11:29:35 -0000 > -----Original Message----- > From: Wodkowski, PawelX > Sent: Monday, March 09, 2015 11:09 AM > To: Ananyev, Konstantin; Vlad Zolotarov; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups >=20 > On 2015-03-09 11:49, Ananyev, Konstantin wrote: > > > > > >> -----Original Message----- > >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Vlad Zolotarov > >> Sent: Monday, March 09, 2015 10:21 AM > >> To: dev@dpdk.org > >> Subject: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups > >> > >> - Removed the not needed casting. > >> - ixgbe_dev_rx_init(): shorten the lines by defining a local alias= variable to access > >> &dev->data->dev_conf.rxmode. > >> > >> Signed-off-by: Vlad Zolotarov > >> --- > >> lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 27 ++++++++++++--------------- > >> 1 file changed, 12 insertions(+), 15 deletions(-) > >> > >> diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/= ixgbe_rxtx.c > >> index 72c65df..609b5fd 100644 > >> --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > >> +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > >> @@ -1032,8 +1032,7 @@ ixgbe_rx_alloc_bufs(struct igb_rx_queue *rxq) > >> int diag, i; > >> > >> /* allocate buffers in bulk directly into the S/W ring */ > >> - alloc_idx =3D (uint16_t)(rxq->rx_free_trigger - > >> - (rxq->rx_free_thresh - 1)); > >> + alloc_idx =3D rxq->rx_free_trigger - (rxq->rx_free_thresh - 1); > > > > I think all these extra casts came in to keep icc 12.* compiling withou= t warnings. > > I am agree that they are unnecessary. > > Though if we still have to support icc 12.* we either need to keep them= , or find > > some other way to keep it happy. > > Konstantin > > >=20 > What warnings icc 12.* is throwing?=20 Try and see :) >Only warning I can think of here is > signed -> unsigned implicit cast.=20 If I remember things correctly, it considered result at right side of '=3D'= operator as unsigned int, and then complained that we assign it to smaller size (unsigned short) oper= and. =20 >Changing '1' to '1U' helps? Don't think so, but you are welcome to try. Konstantin >=20 >=20 > -- > Pawel