From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 74FC89A94 for ; Mon, 9 Mar 2015 17:39:52 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 09 Mar 2015 09:39:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,368,1422950400"; d="scan'208";a="677387569" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga001.fm.intel.com with ESMTP; 09 Mar 2015 09:39:50 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.117]) by IRSMSX103.ger.corp.intel.com ([169.254.3.247]) with mapi id 14.03.0195.001; Mon, 9 Mar 2015 16:39:50 +0000 From: "Ananyev, Konstantin" To: Vlad Zolotarov , "Wodkowski, PawelX" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups Thread-Index: AQHQWlmA9ui88v3CaE+Oi3QRrjwggp0UAdWggABNFwCAAAtcwA== Date: Mon, 9 Mar 2015 16:39:50 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213F4E68@irsmsx105.ger.corp.intel.com> References: <1425896433-12452-1-git-send-email-vladz@cloudius-systems.com> <1425896433-12452-2-git-send-email-vladz@cloudius-systems.com> <2601191342CEEE43887BDE71AB977258213F4B37@irsmsx105.ger.corp.intel.com> <54FD7F5A.4090809@intel.com> <2601191342CEEE43887BDE71AB977258213F4B99@irsmsx105.ger.corp.intel.com> <54FDC306.4030503@cloudius-systems.com> In-Reply-To: <54FDC306.4030503@cloudius-systems.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2015 16:39:53 -0000 > -----Original Message----- > From: Vlad Zolotarov [mailto:vladz@cloudius-systems.com] > Sent: Monday, March 09, 2015 3:58 PM > To: Ananyev, Konstantin; Wodkowski, PawelX; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups >=20 >=20 >=20 > On 03/09/15 13:29, Ananyev, Konstantin wrote: > > > >> -----Original Message----- > >> From: Wodkowski, PawelX > >> Sent: Monday, March 09, 2015 11:09 AM > >> To: Ananyev, Konstantin; Vlad Zolotarov; dev@dpdk.org > >> Subject: Re: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups > >> > >> On 2015-03-09 11:49, Ananyev, Konstantin wrote: > >>> > >>>> -----Original Message----- > >>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Vlad Zolotarov > >>>> Sent: Monday, March 09, 2015 10:21 AM > >>>> To: dev@dpdk.org > >>>> Subject: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups > >>>> > >>>> - Removed the not needed casting. > >>>> - ixgbe_dev_rx_init(): shorten the lines by defining a local al= ias variable to access > >>>> &dev->data->dev_conf.rxmode. > >>>> > >>>> Signed-off-by: Vlad Zolotarov > >>>> --- > >>>> lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 27 ++++++++++++--------------= - > >>>> 1 file changed, 12 insertions(+), 15 deletions(-) > >>>> > >>>> diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgb= e/ixgbe_rxtx.c > >>>> index 72c65df..609b5fd 100644 > >>>> --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > >>>> +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > >>>> @@ -1032,8 +1032,7 @@ ixgbe_rx_alloc_bufs(struct igb_rx_queue *rxq) > >>>> int diag, i; > >>>> > >>>> /* allocate buffers in bulk directly into the S/W ring */ > >>>> - alloc_idx =3D (uint16_t)(rxq->rx_free_trigger - > >>>> - (rxq->rx_free_thresh - 1)); > >>>> + alloc_idx =3D rxq->rx_free_trigger - (rxq->rx_free_thresh - 1); > >>> I think all these extra casts came in to keep icc 12.* compiling with= out warnings. > >>> I am agree that they are unnecessary. > >>> Though if we still have to support icc 12.* we either need to keep th= em, or find > >>> some other way to keep it happy. > >>> Konstantin > >>> > >> What warnings icc 12.* is throwing? > > Try and see :) > > > >> Only warning I can think of here is > >> signed -> unsigned implicit cast. > > If I remember things correctly, it considered result at right side of '= =3D' operator as unsigned int, > > and then complained that we assign it to smaller size (unsigned short) = operand. >=20 > If that's the case - that's a clear compiler bug. Might be, though if we still have to support it, there is no much choice I = am afraid. >=20 > > > >> Changing '1' to '1U' helps? > > Don't think so, but you are welcome to try. > > > > Konstantin > > > >> > >> -- > >> Pawel