From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 226C05A68 for ; Wed, 11 Mar 2015 12:38:36 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 11 Mar 2015 04:32:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,381,1422950400"; d="scan'208";a="663652716" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga001.jf.intel.com with ESMTP; 11 Mar 2015 04:37:38 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.117]) by IRSMSX151.ger.corp.intel.com ([169.254.4.7]) with mapi id 14.03.0195.001; Wed, 11 Mar 2015 11:37:38 +0000 From: "Ananyev, Konstantin" To: Vlad Zolotarov , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 2/3] ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices Thread-Index: AQHQWoZCT9NcF4/Uo0Gm1Mz91+/YM50XKPOg Date: Wed, 11 Mar 2015 11:37:37 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213F5692@irsmsx105.ger.corp.intel.com> References: <1425918532-8601-1-git-send-email-vladz@cloudius-systems.com> <1425918532-8601-3-git-send-email-vladz@cloudius-systems.com> In-Reply-To: <1425918532-8601-3-git-send-email-vladz@cloudius-systems.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/3] ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Mar 2015 11:38:37 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Vlad Zolotarov > Sent: Monday, March 09, 2015 4:29 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 2/3] ixgbe: Bug fix: Properly configure Rx = CRC stripping for x540 devices >=20 > According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should > be configured to the same value as HLREG0.RXCRCSTRP. >=20 > Clearing the RDRXCTL.RSCFRSTSIZE field for x540 is not required by the sp= ec > but seems harmless. Acked-by: Konstantin Ananyev >=20 > Signed-off-by: Vlad Zolotarov > --- > lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixg= be_rxtx.c > index b033e04..ce9658e 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > @@ -3677,7 +3677,8 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev) >=20 > IXGBE_WRITE_REG(hw, IXGBE_RXCSUM, rxcsum); >=20 > - if (hw->mac.type =3D=3D ixgbe_mac_82599EB) { > + if (hw->mac.type =3D=3D ixgbe_mac_82599EB || > + hw->mac.type =3D=3D ixgbe_mac_X540) { > rdrxctl =3D IXGBE_READ_REG(hw, IXGBE_RDRXCTL); > if (dev->data->dev_conf.rxmode.hw_strip_crc) > rdrxctl |=3D IXGBE_RDRXCTL_CRCSTRIP; > -- > 2.1.0