From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 945975A13 for ; Wed, 18 Mar 2015 16:24:32 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 18 Mar 2015 08:24:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,423,1422950400"; d="scan'208";a="681926280" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga001.fm.intel.com with ESMTP; 18 Mar 2015 08:24:07 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.117]) by IRSMSX108.ger.corp.intel.com ([169.254.11.218]) with mapi id 14.03.0195.001; Wed, 18 Mar 2015 15:24:06 +0000 From: "Ananyev, Konstantin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] EAL: move rte_common_vect.h into arch/x86 Thread-Index: AQHQYWp3JV36C5LPU0yIGkxmpnNSr50iN+uAgAAiDZA= Date: Wed, 18 Mar 2015 15:24:05 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258213F71C4@irsmsx105.ger.corp.intel.com> References: <1426676283-7779-1-git-send-email-konstantin.ananyev@intel.com> <12406601.aPV9NrFM6W@xps13> In-Reply-To: <12406601.aPV9NrFM6W@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] EAL: move rte_common_vect.h into arch/x86 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Mar 2015 15:24:33 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, March 18, 2015 1:14 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] EAL: move rte_common_vect.h into arch/x86 >=20 > Hi Konstantin, >=20 > 2015-03-18 10:58, Konstantin Ananyev: > > lib/librte_eal/common/Makefile | 1 - > > .../common/include/arch/x86/rte_common_vect.h | 128 +++++++++++++= ++++++++ > > lib/librte_eal/common/include/rte_common_vect.h | 128 -------------= -------- >=20 > I think rte_vect.h is a better name as common is not anymore relevant. I don't mind, but it means more changes - all files which include it, would= need to be changed. =20 > Should we add an empty file in ppc_64 directory? I thought about that too, but it seems not necessary. It is included by: lib/librte_lpm/rte_lpm.h lib/librte_eal/common/include/arch/x86/rte_memcpy.h lib/librte_acl/rte_acl_osdep.h=20 As I understand, neither LPM, neither ACL are supported on PPC right now. Again, if we'll provide an empty one for PPC, it wouldn't help to compile L= PM/ACL on PPC anyway, as both use SSE instrincts inside their code. Konstantin=20