DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Vlad Zolotarov <vladz@cloudius-systems.com>,
	Thomas Monjalon <thomas.monjalon@6wind.com>,
	"Zhang, Helin" <helin.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix build with gcc 4.4
Date: Tue, 14 Apr 2015 13:06:54 +0000	[thread overview]
Message-ID: <2601191342CEEE43887BDE71AB9772582141570C@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <552D0CA2.9080905@cloudius-systems.com>



> -----Original Message-----
> From: Vlad Zolotarov [mailto:vladz@cloudius-systems.com]
> Sent: Tuesday, April 14, 2015 1:49 PM
> To: Thomas Monjalon; Ananyev, Konstantin; Zhang, Helin
> Cc: dev@dpdk.org
> Subject: Re: [PATCH] ixgbe: fix build with gcc 4.4
> 
> 
> 
> On 04/14/15 12:31, Thomas Monjalon wrote:
> > With GCC 4.4.7 from CentOS 6.5, the following errors arise:
> >
> > lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function ‘ixgbe_dev_rx_queue_setup’:
> > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: missing initializer
> > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: (near initialization for ‘dev_info.driver_name’)
> >
> > lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function ‘ixgbe_set_rsc’:
> > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:4072: error: missing initializer
> > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:4072: error: (near initialization for ‘dev_info.driver_name’)
> >
> > lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function ‘ixgbe_recv_pkts_lro_single_alloc’:
> > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1479: error: ‘next_rsc_entry’ may be used uninitialized in this function
> > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1480: error: ‘next_rxe’ may be used uninitialized in this function
> >
> > Fixes: 8eecb3295aed ("ixgbe: add LRO support")
> >
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > ---
> >   lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 8 ++++----
> >   1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> > index f1da9ec..a2b8631 100644
> > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> > @@ -1476,8 +1476,8 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts,
> >   		bool eop;
> >   		struct ixgbe_rx_entry *rxe;
> >   		struct ixgbe_rsc_entry *rsc_entry;
> > -		struct ixgbe_rsc_entry *next_rsc_entry;
> > -		struct ixgbe_rx_entry *next_rxe;
> > +		struct ixgbe_rsc_entry *next_rsc_entry = NULL;
> > +		struct ixgbe_rx_entry *next_rxe = NULL;
> >   		struct rte_mbuf *first_seg;
> >   		struct rte_mbuf *rxm;
> >   		struct rte_mbuf *nmb;
> > @@ -2506,7 +2506,7 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_dev *dev,
> >   	struct ixgbe_rx_queue *rxq;
> >   	struct ixgbe_hw     *hw;
> >   	uint16_t len;
> > -	struct rte_eth_dev_info dev_info = { 0 };
> > +	struct rte_eth_dev_info dev_info = { .max_rx_queues = 0 };
> >   	struct rte_eth_rxmode *dev_rx_mode = &dev->data->dev_conf.rxmode;
> >   	bool rsc_requested = false;
> >
> > @@ -4069,7 +4069,7 @@ ixgbe_set_rsc(struct rte_eth_dev *dev)
> >   {
> >   	struct rte_eth_rxmode *rx_conf = &dev->data->dev_conf.rxmode;
> >   	struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> > -	struct rte_eth_dev_info dev_info = { 0 };
> > +	struct rte_eth_dev_info dev_info = { .max_rx_queues = 0 };
> 
> Hmmm... Unless I miss something this and one above would zero only a
> single field - "max_rx_queues"; and would leave the rest uninitialized.
> The original code intend to zero the whole struct. The alternative to
> the original lines could be usage of memset().

As I understand, in that case compiler had to set all non-explicitly initialised members to 0.
So I think we are ok here.
 
> 
> >   	bool rsc_capable = false;
> >   	uint16_t i;
> >   	uint32_t rdrxctl;


  reply	other threads:[~2015-04-14 13:07 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-14  9:31 Thomas Monjalon
2015-04-14 12:48 ` Vlad Zolotarov
2015-04-14 13:06   ` Ananyev, Konstantin [this message]
2015-04-14 13:38     ` Vlad Zolotarov
2015-04-14 14:17       ` Thomas Monjalon
2015-04-14 14:30         ` Vlad Zolotarov
2015-04-14 14:53           ` Thomas Monjalon
2015-04-14 15:17             ` Vlad Zolotarov
2015-04-14 14:59         ` Vlad Zolotarov
2015-04-14 15:13           ` Thomas Monjalon
2015-04-14 15:21             ` Vlad Zolotarov
2015-04-14 15:28               ` Thomas Monjalon
2015-04-14 15:32                 ` Vlad Zolotarov
2015-04-15 20:49                 ` [dpdk-dev] [PATCH v2 1/2] " Thomas Monjalon
2015-04-15 20:49                   ` [dpdk-dev] [PATCH v2 2/2] use simple zero initializers Thomas Monjalon
2015-04-16 10:12                     ` Olivier MATZ
2015-04-16 12:55                       ` Thomas Monjalon
2015-04-16 16:31                         ` Mcnamara, John
2015-04-16  7:26                   ` [dpdk-dev] [PATCH v2 1/2] ixgbe: fix build with gcc 4.4 Zhang, Helin
2015-04-16  9:14                   ` Vlad Zolotarov
2015-04-16  9:18                     ` Thomas Monjalon
2015-04-16  9:35                       ` Vlad Zolotarov
2015-04-16 22:10                   ` [dpdk-dev] [PATCH v3 1/2] mk: fix build with gcc 4.4 and clang Thomas Monjalon
2015-04-16 22:10                     ` [dpdk-dev] [PATCH v3 2/2] use simple zero initializers Thomas Monjalon
2015-04-17 11:17                       ` Mcnamara, John
2015-04-19  8:22                       ` Vlad Zolotarov
2015-04-20 12:45                         ` Thomas Monjalon
2015-04-17 11:15                     ` [dpdk-dev] [PATCH v3 1/2] mk: fix build with gcc 4.4 and clang Mcnamara, John
2015-04-19  8:21                     ` Vlad Zolotarov
2015-04-20 12:44                       ` Thomas Monjalon
2015-04-14 12:51 ` [dpdk-dev] [PATCH] ixgbe: fix build with gcc 4.4 Vlad Zolotarov
2015-04-14 13:23   ` Ananyev, Konstantin
2015-04-14 13:41     ` Vlad Zolotarov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2601191342CEEE43887BDE71AB9772582141570C@irsmsx105.ger.corp.intel.com \
    --to=konstantin.ananyev@intel.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=thomas.monjalon@6wind.com \
    --cc=vladz@cloudius-systems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).