From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 65952B3D6 for ; Tue, 26 May 2015 17:04:05 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 26 May 2015 08:03:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,498,1427785200"; d="scan'208";a="576975959" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga003.jf.intel.com with ESMTP; 26 May 2015 08:03:30 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.73]) by IRSMSX109.ger.corp.intel.com ([169.254.13.51]) with mapi id 14.03.0224.002; Tue, 26 May 2015 16:02:51 +0100 From: "Ananyev, Konstantin" To: Stephen Hemminger , "Zhang, Helin" Thread-Topic: [dpdk-dev] [PATCH 2/5] mbuf: use the reserved 16 bits for double vlan Thread-Index: AQHQl48oHVvv7PLtz0eIGnJC6jZO0J2OSBCAgAARNOA= Date: Tue, 26 May 2015 15:02:51 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725821431C8F@irsmsx105.ger.corp.intel.com> References: <1430793143-3610-1-git-send-email-helin.zhang@intel.com> <1432629400-25303-1-git-send-email-helin.zhang@intel.com> <1432629400-25303-3-git-send-email-helin.zhang@intel.com> <20150526075515.1bc42ae1@urahara> In-Reply-To: <20150526075515.1bc42ae1@urahara> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 2/5] mbuf: use the reserved 16 bits for double vlan X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2015 15:04:06 -0000 Hi Stephen, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Tuesday, May 26, 2015 3:55 PM > To: Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/5] mbuf: use the reserved 16 bits for do= uble vlan >=20 > On Tue, 26 May 2015 16:36:37 +0800 > Helin Zhang wrote: >=20 > > Use the reserved 16 bits in rte_mbuf structure for the outer vlan, > > also add QinQ offloading flags for both RX and TX sides. > > > > Signed-off-by: Helin Zhang >=20 > Yet another change that is much needed, but breaks ABI compatibility. Why do you think it breaks ABI compatibility? As I can see, it uses field that was reserved. Konstantin