From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: David Marchand <david.marchand@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix TSO in IPv6
Date: Mon, 15 Jun 2015 12:39:48 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725836A0A646@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1433160677-20847-1-git-send-email-david.marchand@6wind.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Marchand
> Sent: Monday, June 01, 2015 1:11 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] ixgbe: fix TSO in IPv6
>
> From: Didier Pallard <didier.pallard@6wind.com>
>
> When TSO is used with IPv6, generated frames are incorrect.
> L4 frame is OK, but length field of IPv6 header was not populated correctly.
>
> Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
> ---
> drivers/net/ixgbe/ixgbe_rxtx.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
> index 4f9ab22..d123612 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -375,10 +375,15 @@ ixgbe_set_xmit_ctx(struct ixgbe_tx_queue *txq,
>
> /* check if TCP segmentation required for this packet */
> if (ol_flags & PKT_TX_TCP_SEG) {
> - /* implies IP cksum and TCP cksum */
> - type_tucmd_mlhl = IXGBE_ADVTXD_TUCMD_IPV4 |
> - IXGBE_ADVTXD_TUCMD_L4T_TCP |
> - IXGBE_ADVTXD_DTYP_CTXT | IXGBE_ADVTXD_DCMD_DEXT;
> + /* implies IP cksum in IPv4 */
> + if (ol_flags & PKT_TX_IP_CKSUM)
> + type_tucmd_mlhl = IXGBE_ADVTXD_TUCMD_IPV4 |
> + IXGBE_ADVTXD_TUCMD_L4T_TCP |
> + IXGBE_ADVTXD_DTYP_CTXT | IXGBE_ADVTXD_DCMD_DEXT;
> + else
> + type_tucmd_mlhl =
> + IXGBE_ADVTXD_TUCMD_L4T_TCP |
> + IXGBE_ADVTXD_DTYP_CTXT | IXGBE_ADVTXD_DCMD_DEXT;
>
> tx_offload_mask.l2_len |= ~0;
> tx_offload_mask.l3_len |= ~0;
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 1.7.10.4
next prev parent reply other threads:[~2015-06-15 12:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 12:11 David Marchand
2015-06-15 9:45 ` Thomas Monjalon
2015-06-16 1:28 ` Zhang, Helin
2015-06-15 12:39 ` Ananyev, Konstantin [this message]
2015-06-16 1:27 ` Zhang, Helin
2015-06-22 14:21 ` [dpdk-dev] [PATCH v2] " David Marchand
2015-06-22 14:23 ` Zhang, Helin
2015-06-22 14:59 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB97725836A0A646@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).