From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 2AB14C5D8
 for <dev@dpdk.org>; Tue, 23 Jun 2015 23:55:44 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga101.fm.intel.com with ESMTP; 23 Jun 2015 14:21:20 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,668,1427785200"; d="scan'208";a="733276216"
Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25])
 by fmsmga001.fm.intel.com with ESMTP; 23 Jun 2015 14:21:19 -0700
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.245]) by
 irsmsx110.ger.corp.intel.com ([163.33.3.25]) with mapi id 14.03.0224.002;
 Tue, 23 Jun 2015 22:21:18 +0100
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Cyril Chemparathy <cchemparathy@ezchip.com>
Thread-Topic: [dpdk-dev] [PATCH v2 08/12] mempool: allow config override on
 element alignment
Thread-Index: AQHQrfVBJU9qTSX+JE+WDEBMFSWBtZ26mO8Q
Date: Tue, 23 Jun 2015 21:21:17 +0000
Message-ID: <2601191342CEEE43887BDE71AB97725836A1D40D@irsmsx105.ger.corp.intel.com>
References: <1434999524-26528-1-git-send-email-cchemparathy@ezchip.com>
 <1434999524-26528-9-git-send-email-cchemparathy@ezchip.com>
 <2601191342CEEE43887BDE71AB97725836A1CDB8@irsmsx105.ger.corp.intel.com>
 <20150623134304.55c7233d@cchemparathy-ubuntu>
In-Reply-To: <20150623134304.55c7233d@cchemparathy-ubuntu>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 08/12] mempool: allow config override on
 element alignment
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Jun 2015 21:55:44 -0000



> -----Original Message-----
> From: Cyril Chemparathy [mailto:cchemparathy@ezchip.com]
> Sent: Tuesday, June 23, 2015 9:43 PM
> To: Ananyev, Konstantin
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 08/12] mempool: allow config override o=
n element alignment
>=20
> On Tue, 23 Jun 2015 00:31:06 +0000
> "Ananyev, Konstantin" <konstantin.ananyev@intel.com> wrote:
>=20
> > > +#define RTE_MEMPOOL_ALIGN_MASK	(RTE_MEMPOOL_ALIGN - 1)
> >
> > I am probably a bit late with my comments, but why not make it a
> > runtime decision then? I know we can't add a new parameter to
> > mempool_xmem_create() without ABI breakage, but we can make some
> > global variable for now, that could be setup at init time or
> > something similar.
>=20
> But then, a global variable that is modified by an application _is_ a
> part of the ABI, and a bad one at that.
>=20
> I agree with the desire to make it runtime configurable, but I think we
> should do so in the right spirit, with the appropriate interfaces, and
> when we're open to changing the ABI accordingly.

Ok, let's wait till next release then.
Konstantin

>=20
> Thanks
> -- Cyril.