From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 25F50C336 for ; Thu, 23 Jul 2015 12:52:14 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 23 Jul 2015 03:52:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,529,1432623600"; d="scan'208";a="769767287" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga002.jf.intel.com with ESMTP; 23 Jul 2015 03:52:12 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.223]) by IRSMSX103.ger.corp.intel.com ([169.254.3.149]) with mapi id 14.03.0224.002; Thu, 23 Jul 2015 11:52:11 +0100 From: "Ananyev, Konstantin" To: Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCHv4 1/5] ethdev: add new API to retrieve RX/TX queue information Thread-Index: AQHQxK9QOtJCAJwhl0KZym7kHYZQWJ3n1IAAgAEJCPA= Date: Thu, 23 Jul 2015 10:52:11 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836A64BE0@irsmsx105.ger.corp.intel.com> References: <1437589735-30041-1-git-send-email-konstantin.ananyev@intel.com> <1437589735-30041-2-git-send-email-konstantin.ananyev@intel.com> <20150722124802.6a0f4745@urahara> In-Reply-To: <20150722124802.6a0f4745@urahara> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCHv4 1/5] ethdev: add new API to retrieve RX/TX queue information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2015 10:52:14 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Wednesday, July 22, 2015 8:48 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCHv4 1/5] ethdev: add new API to retrieve RX/= TX queue information >=20 > On Wed, 22 Jul 2015 19:28:51 +0100 > Konstantin Ananyev wrote: >=20 > > Add the ability for the upper layer to query RX/TX queue information. > > > > Add new structures: > > struct rte_eth_rxq_info > > struct rte_eth_txq_info > > > > new functions: > > rte_eth_rx_queue_info_get > > rte_eth_tx_queue_info_get > > > > into rte_etdev API. > > > > Left extra free space in the queue info structures, > > so extra fields could be added later without ABI breakage. > > > > v2 changes: > > - Add formal check for the qinfo input parameter. > > - As suggested rename 'rx_qinfo/tx_qinfo' to 'rxq_info/txq_info' > > > > v3 changes: > > - Updated rte_ether_version.map > > - Merged with latest changes > > > > v4 changes: > > - rte_ether_version.map: move new functions into DPDK_2.1 sub-space. > > > > Signed-off-by: Konstantin Ananyev >=20 > Since all this data should be rxconf already, Is it possible > to do a generic version of this and not have to change every driver. I don't think it is possible to implement these two functions at rte_etdev = level only. At least not with current ethdev/PMD implementation: - Inside struct rte_eth_dev_info we have only: 'struct rte_eth_rxconf defa= ult_rxconf;'. We don't have rxconf here for each configured rx queue. That information is maintained by PMD and inside PMD, different devices hav= e different format for queue structure. - rte_eth_rxq_info contains not only rxconf but some extra information: mem= pool in use by that queue, min/max possible number of descriptors. Also my intention was that in future that structure would be extended to p= rovide some RT info about queue: (number of free/used descriptors from SW point of view, etc). =20 Konstantin >=20 > You only handled the Intel hardware drivers. But there also > all the virtual drivers, other vendors etc.