From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A0E8BC3F8 for ; Fri, 24 Jul 2015 11:05:13 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 24 Jul 2015 02:05:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,537,1432623600"; d="scan'208";a="734730067" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga001.jf.intel.com with ESMTP; 24 Jul 2015 02:05:11 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX107.ger.corp.intel.com (163.33.3.99) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 24 Jul 2015 10:05:10 +0100 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.223]) by IRSMSX156.ger.corp.intel.com ([169.254.3.27]) with mapi id 14.03.0224.002; Fri, 24 Jul 2015 10:05:10 +0100 From: "Ananyev, Konstantin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCHv4 1/5] ethdev: add new API to retrieve RX/TX queue information Thread-Index: AQHQxK9QOtJCAJwhl0KZym7kHYZQWJ3n1IAAgAEJCPCAAE51gIABKIRw Date: Fri, 24 Jul 2015 09:05:10 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836A671C4@irsmsx105.ger.corp.intel.com> References: <1437589735-30041-1-git-send-email-konstantin.ananyev@intel.com> <20150722124802.6a0f4745@urahara> <2601191342CEEE43887BDE71AB97725836A64BE0@irsmsx105.ger.corp.intel.com> <1441832.QYmNKRXLMA@xps13> In-Reply-To: <1441832.QYmNKRXLMA@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCHv4 1/5] ethdev: add new API to retrieve RX/TX queue information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2015 09:05:14 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, July 23, 2015 5:17 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCHv4 1/5] ethdev: add new API to retrieve RX/= TX queue information >=20 > 2015-07-23 10:52, Ananyev, Konstantin: > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > > Konstantin Ananyev wrote: > > > > Add the ability for the upper layer to query RX/TX queue informatio= n. > [...] > > > Since all this data should be rxconf already, Is it possible > > > to do a generic version of this and not have to change every driver. > > > > I don't think it is possible to implement these two functions at rte_et= dev level only. > > At least not with current ethdev/PMD implementation: > > - Inside struct rte_eth_dev_info we have only: 'struct rte_eth_rxconf = default_rxconf;'. > > We don't have rxconf here for each configured rx queue. > > That information is maintained by PMD and inside PMD, different devices= have different format for queue structure. > > - rte_eth_rxq_info contains not only rxconf but some extra information:= mempool in use by that queue, > > min/max possible number of descriptors. > > Also my intention was that in future that structure would be extended = to provide some RT info about queue: > > (number of free/used descriptors from SW point of view, etc). >=20 > Isn't it what rte_eth_rx_queue_count() provides? Not exactly. rte_eth_rx_queue_count() actually scans HW descriptors to check their statu= s. I was thinking about returning just a snapshot of SW state: how many free/u= sed RXDs are from PMD perspective (just by collecting info from *_rx_queue structure, without reading actual = HW registers/descriptors). Anyway, right now it is not implemented - it is just a thought for future e= xpansion. Konstantin > Maybe we should deprecate it in favor of rte_eth_rx_queue_info_get().