From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 05E7BC404 for ; Fri, 24 Jul 2015 12:50:50 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 24 Jul 2015 03:50:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,538,1432623600"; d="scan'208";a="770428468" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga002.jf.intel.com with ESMTP; 24 Jul 2015 03:50:48 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.223]) by IRSMSX153.ger.corp.intel.com ([169.254.9.59]) with mapi id 14.03.0224.002; Fri, 24 Jul 2015 11:50:47 +0100 From: "Ananyev, Konstantin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCHv4 1/5] ethdev: add new API to retrieve RX/TX queue information Thread-Index: AQHQxK9QOtJCAJwhl0KZym7kHYZQWJ3pLn8AgAEn77D///SDAIAAJmng Date: Fri, 24 Jul 2015 10:50:46 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836A6723D@irsmsx105.ger.corp.intel.com> References: <1437589735-30041-1-git-send-email-konstantin.ananyev@intel.com> <1781257.Eo9CaUGVAh@xps13> <2601191342CEEE43887BDE71AB97725836A671DF@irsmsx105.ger.corp.intel.com> <2058063.jaPb6Gx79p@xps13> In-Reply-To: <2058063.jaPb6Gx79p@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCHv4 1/5] ethdev: add new API to retrieve RX/TX queue information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2015 10:50:51 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, July 24, 2015 10:24 AM > To: Ananyev, Konstantin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCHv4 1/5] ethdev: add new API to retrieve RX/= TX queue information >=20 > 2015-07-24 09:15, Ananyev, Konstantin: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2015-07-22 19:28, Konstantin Ananyev: > > > > +struct rte_eth_rxq_info { > > > > + struct rte_mempool *mp; /**< mempool used by that queue. */ > > > > + struct rte_eth_rxconf conf; /**< queue config parameters. */ > > > > + uint8_t scattered_rx; /**< scattered packets RX supported. = */ > > > > + uint16_t nb_desc; /**< configured number of RXDs. */ > > > > > > Shouldn't we move nb_desc in rte_eth_rxconf? > > > So rte_eth_rx_queue_setup() would have less parameters. > > > > I thought about that too, but it seems more drawbacks then pluses with = that idea: > > 1. Right now it is possible to call rte_eth_rx_queue_setup(..., rx_conf= =3DNULL, ...); > > In that case rte_eth_rx_queue_setup()will use default for that device r= x_conf. > > If we'll move mempool into rxconf, will break that ability. > > 2. A bit unclear what mempool should be returned as default_rxconf by = rte_eth_dev_info_get(). > > Should it be just NULL. >=20 > I was only suggesting to move nb_desc, not mempool. Ah, sorry didn't read it properly first time. Yes, I think it makes sense to move nb_desc into rxconf, though that means = ABI breakage, and that patch would definitely not make into 2.1.=20 > In case rx_conf=3D=3DNULL, the nb_desc should be the max allowed by the d= river. In my opinion it should be 'preferable by default' PMD value. Plus, rte_eth_dev_info should contain min_rx_desc and max_rx_desc, so user can select nb_rx_desc from the allowed interval, if he needs to. Konstantin > By the way, we should allow nb_desc=3D=3D0 as it is done in virtio. > Users shouldn't have to care about queue parameters (including nb_desc) f= or > a basic usage. >=20 > > 3. ABI breakage and we (and all customers) will need to modify each an= d every RX setup/configure code. > > > > For me it just seems like too much hassle, without any clear advanatage= . >=20 > The advantage is to have a cleaner API. Seems important to me.