From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 7B0BADE0 for ; Mon, 27 Jul 2015 16:43:28 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 27 Jul 2015 07:43:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,554,1432623600"; d="scan'208";a="736415857" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by orsmga001.jf.intel.com with ESMTP; 27 Jul 2015 07:43:27 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX108.ger.corp.intel.com (163.33.3.3) with Microsoft SMTP Server (TLS) id 14.3.224.2; Mon, 27 Jul 2015 15:43:25 +0100 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.223]) by IRSMSX156.ger.corp.intel.com ([169.254.3.27]) with mapi id 14.03.0224.002; Mon, 27 Jul 2015 15:43:25 +0100 From: "Ananyev, Konstantin" To: Thomas Monjalon Thread-Topic: [PATCH v4] enforce rules of the cpu and ixgbe exchange data. Thread-Index: AQHQv5tYy9zLhBlqeUS3WVXai190wp3vXjiAgAAWB9A= Date: Mon, 27 Jul 2015 14:43:24 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836A68E5D@irsmsx105.ger.corp.intel.com> References: <1437029134-25191-1-git-send-email-xuelin.shi@freescale.com> <2152064.QkQ5mbgbrx@xps13> In-Reply-To: <2152064.QkQ5mbgbrx@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" , "xuelin.shi@freescale.com" Subject: Re: [dpdk-dev] [PATCH v4] enforce rules of the cpu and ixgbe exchange data. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2015 14:43:29 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, July 27, 2015 3:18 PM > To: Ananyev, Konstantin > Cc: xuelin.shi@freescale.com; dev@dpdk.org > Subject: Re: [PATCH v4] enforce rules of the cpu and ixgbe exchange data. >=20 > A quick review of this long pending patch would be great. > Thanks Well, it doesn't compile: /local/kananye1/dpdk.org-ixgbevfix2-tst1/drivers/net/ixgbe/ixgbe_rxtx.c: In= function =E2ixgbe_rx_scan_hw_ring=E2: /local/kananye1/dpdk.org-ixgbevfix2-tst1/drivers/net/ixgbe/ixgbe_rxtx.c:111= 4:4: error: implicit declaration of function =E2rte_le_to_cpu16=E2 [-Werror= =3Dimplicit-function-declaration] pkt_len =3D rte_le_to_cpu16(rxdp[j].wb.upper.length) - ^ /local/kananye1/dpdk.org-ixgbevfix2-tst1/drivers/net/ixgbe/ixgbe_rxtx.c:111= 4:4: error: nested extern declaration of =E2rte_le_to_cpu16=E2 [-Werror=3Dn= ested-externs] Should be rte_le_to_cpu_16(), I believe. And checkpatch.pl complains on it: WARNING: line over 80 characters #151: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:1133: + rte_le_to_cpu_32(rxdp[j].wb.lower.lo_dword.= data)); ERROR: code indent should use tabs where possible #170: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:1147: +^I^I^I ^I rxdp[j].wb.lower.hi_dword.csum_ip.csum) &$ WARNING: please, no space before tabs #170: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:1147: +^I^I^I ^I rxdp[j].wb.lower.hi_dword.csum_ip.csum) &$ total: 1 errors, 2 warnings, 192 lines checked Apart from that, looks harmless :) Konstantin >=20 > 2015-07-16 14:45, xuelin.shi@freescale.com: > > From: Xuelin Shi > > > > 1. cpu use data owned by ixgbe must use rte_le_to_cpu_xx(...) > > 2. cpu fill data to ixgbe must use rte_cpu_to_le_xx(...) > > 3. checking pci status with converted constant. > > > > Signed-off-by: Xuelin Shi