DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Qiu, Michael" <michael.qiu@intel.com>,
	"Zhang, Helin" <helin.zhang@intel.com>,
	Thomas Monjalon <thomas.monjalon@6wind.com>,
	"Liu, Yong" <yong.liu@intel.com>,
	"Cao, Waterman" <waterman.cao@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC] examples: remove l3fwd-vf example
Date: Tue, 4 Aug 2015 17:12:29 +0000	[thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725836A6DCA7@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <533710CFB86FA344BFBF2D6802E60286046FF05F@SHSMSX101.ccr.corp.intel.com>



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiu, Michael
> Sent: Tuesday, August 04, 2015 6:06 PM
> To: Zhang, Helin; Thomas Monjalon; Liu, Yong; Cao, Waterman
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [RFC] examples: remove l3fwd-vf example
> 
> Actually, l3fwd works fine with fm10k vf.
> 
> I don't know what's the exact reason of l3fwd-vf still in DPDK, at least we could make full support for vf in l3fwd instead of another
> sample with most code are the same compare with l3fwd.

Right now, l3fwd is not able to work properly for cases where number of forwarding  lcores 
exceeds number of tx queues on any active port.
As an example: 
2 forwarding lcores and a port with just 1 TX queue (e1000 legacy device).

 To make l3fwd work for such cases you need to add some sort of synchronisation on TX path.
 Which means one of 2 ways:
 either introduce different TX path into l3fwd (one with sync if legacy/virual device is used, another without)
 and select it on process startup/config phase,
 or sync overhead for fastpath.

Konstantin

> 
> Thanks,
> Michael
> 
> On 2015/7/22 7:51, Zhang, Helin wrote:
> 
> Marvin/Waterman
> 
> Could you help to check if l3fwd is good enough for all cases (1g/10/40g, PF and VF, single queue/multiple queue)?
> We aim to remove l3fwd-vf to reduce an example application which is not so necessary.
> Thank you!
> 
> Regards,
> Helin
> 
> 
> 
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, July 22, 2015 3:30 AM
> To: Zhang, Helin
> Cc: dev@dpdk.org<mailto:dev@dpdk.org>; Wu, Jingjing
> Subject: Re: [dpdk-dev] [RFC] examples: remove l3fwd-vf example
> 
> 2015-07-14 14:50, Zhang, Helin:
> 
> 
> From: Wu, Jingjing
> 
> 
> Because VF multi-queues can be supported, l3fwd can run on vf.
> Suggest to remove the l3fwd-vf example.
> 
> 
> Totally agree with this!
> But we need the confirmation from validation guys of that l3fwd works
> quite well on VF with all NICs (e.g. i350, 82599, x550, xl710, and fm10k).
> 
> 
> 
> Helin, any new from validation?
> 
> 
> 
> 

  reply	other threads:[~2015-08-04 17:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-14  7:57 Jingjing Wu
2015-07-14  8:20 ` Jayakumar, Muthurajan
2015-07-14  8:28   ` Thomas Monjalon
2015-07-15  0:54     ` Wu, Jingjing
2015-07-14 14:50 ` Zhang, Helin
2015-07-22 10:30   ` Thomas Monjalon
2015-07-22 14:51     ` Zhang, Helin
2015-07-22 15:01       ` Ananyev, Konstantin
2015-08-03 16:54       ` Thomas Monjalon
2015-08-03 17:02         ` Zhang, Helin
2015-08-03 17:08           ` Thomas Monjalon
2015-08-04 17:06       ` Qiu, Michael
2015-08-04 17:12         ` Ananyev, Konstantin [this message]
2016-04-20 10:46           ` Thomas Monjalon
2016-04-20 11:16             ` Ananyev, Konstantin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2601191342CEEE43887BDE71AB97725836A6DCA7@irsmsx105.ger.corp.intel.com \
    --to=konstantin.ananyev@intel.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=michael.qiu@intel.com \
    --cc=thomas.monjalon@6wind.com \
    --cc=waterman.cao@intel.com \
    --cc=yong.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).