From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Liang, Cunming" <cunming.liang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] ixgbe: remove vector pmd burst size restriction
Date: Wed, 5 Aug 2015 09:31:23 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725836A6DF18@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1438688832-15396-1-git-send-email-cunming.liang@intel.com>
> -----Original Message-----
> From: Liang, Cunming
> Sent: Tuesday, August 04, 2015 12:47 PM
> To: dev@dpdk.org
> Cc: Ananyev, Konstantin; zoltan.kiss@linaro.org; Liang, Cunming
> Subject: [PATCH v3] ixgbe: remove vector pmd burst size restriction
>
> On receive side, the burst size now floor aligns to RTE_IXGBE_DESCS_PER_LOOP power of 2.
> According to this rule, the burst size less than 4 still won't receive anything.
> (Before this change, the burst size less than 32 can't receive anything.)
> _recv_*_pkts_vec returns no more than 32(RTE_IXGBE_RXQ_REARM_THRESH) packets.
>
> On transmit side, the max burst size no longer bind with a constant, however it still
> require to check the cross tx_rs_thresh violation.
>
> There's no obvious performance drop found on both recv_pkts_vec
> and recv_scattered_pkts_vec on burst size 32.
>
> Signed-off-by: Cunming Liang <cunming.liang@intel.com>
> ---
> v3 change:
> - reword the init print log
>
> v2 change:
> - keep max rx burst size in 32
> - reword some comments
>
> drivers/net/ixgbe/ixgbe_rxtx.c | 4 +++-
> drivers/net/ixgbe/ixgbe_rxtx.h | 5 ++---
> drivers/net/ixgbe/ixgbe_rxtx_vec.c | 39 +++++++++++++++++++++-----------------
> 3 files changed, 27 insertions(+), 21 deletions(-)
>
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
next prev parent reply other threads:[~2015-08-05 9:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 8:17 [dpdk-dev] [PATCH v1] " Cunming Liang
2015-07-31 9:21 ` Ananyev, Konstantin
2015-07-31 10:03 ` Zoltan Kiss
2015-07-31 10:21 ` Ananyev, Konstantin
2015-07-31 11:57 ` Zoltan Kiss
2015-07-31 14:49 ` Zoltan Kiss
2015-08-03 7:41 ` Liang, Cunming
2015-08-03 9:59 ` Liang, Cunming
2015-08-03 2:40 ` Liang, Cunming
2015-08-04 7:32 ` [dpdk-dev] [PATCH v2] " Cunming Liang
2015-08-04 9:02 ` Zoltan Kiss
2015-08-04 11:15 ` Liang, Cunming
2015-08-04 11:47 ` [dpdk-dev] [PATCH v3] " Cunming Liang
2015-08-04 16:26 ` Zoltan Kiss
2015-08-05 6:28 ` Liang, Cunming
2015-08-05 15:59 ` Zoltan Kiss
2015-08-05 9:31 ` Ananyev, Konstantin [this message]
2015-09-09 13:16 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB97725836A6DF18@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=cunming.liang@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).