From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 90F02E72 for ; Wed, 23 Sep 2015 10:23:12 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 23 Sep 2015 01:23:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,577,1437462000"; d="scan'208";a="566786294" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by FMSMGA003.fm.intel.com with ESMTP; 23 Sep 2015 01:23:01 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.252]) by irsmsx110.ger.corp.intel.com ([169.254.15.164]) with mapi id 14.03.0248.002; Wed, 23 Sep 2015 09:22:59 +0100 From: "Ananyev, Konstantin" To: "Qiu, Michael" , Stephen Hemminger , "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH v2] ethdev: add new RX/TX queue state arrays in rte_eth_dev_data Thread-Index: AQHQ9L6IqsNfWsFMKE6kSBlhvaUpVZ5JyDWw Date: Wed, 23 Sep 2015 08:22:59 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725836A9B7C2@irsmsx105.ger.corp.intel.com> References: <1442440284-6175-1-git-send-email-pablo.de.lara.guarch@intel.com> <20150921154024.3890eb76@urahara> <533710CFB86FA344BFBF2D6802E602861989289E@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <533710CFB86FA344BFBF2D6802E602861989289E@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2] ethdev: add new RX/TX queue state arrays in rte_eth_dev_data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Sep 2015 08:23:13 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiu, Michael > Sent: Wednesday, September 23, 2015 7:57 AM > To: Stephen Hemminger; De Lara Guarch, Pablo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: add new RX/TX queue state arra= ys in rte_eth_dev_data >=20 > On 2015/9/22 6:40, Stephen Hemminger wrote: > > On Wed, 16 Sep 2015 22:51:24 +0100 > > Pablo de Lara wrote: > > > >> This is important to avoid trying to start/stop twice a queue, > >> which will result in undefined behaviour > >> (which may cause RX/TX disruption). > >> > >> Mind that only the PMDs which have queue_start/stop functions > >> have been changed to update this field, as the functions will > >> check the queue state before switching it. > >> > >> Signed-off-by: Pablo de Lara > > I agree that the DPDK API should check for buggy manipulation > > in the control path. But this should be done in generic code. > > Anything where you have to change any driver is making more work > > than necessary. >=20 > I agree with you, but I have a question, why we need expose the queue > start and stop function to app? >=20 > In my opinion, user app will hardly to start a device but stop the > device queue. what's the purpose of it? >=20 There are use cases when application need to start/stop individual queues. DPDK vhost app would be one of the examples. =20 Konstantin > Thanks, > Michael