From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCHv5 1/8] ethdev: add new API to retrieve RX/TX queue information
Date: Wed, 14 Oct 2015 18:44:38 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725836AAFAC3@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <20151014090904.3d632d92@xeon-e3>
> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Wednesday, October 14, 2015 5:09 PM
> To: Ananyev, Konstantin
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCHv5 1/8] ethdev: add new API to retrieve RX/TX queue information
>
> On Thu, 1 Oct 2015 20:54:46 +0100
> Konstantin Ananyev <konstantin.ananyev@intel.com> wrote:
>
> > + if (nb_rx_desc > dev_info.rx_desc_lim.nb_max ||
> > + nb_rx_desc < dev_info.rx_desc_lim.nb_min ||
> > + nb_rx_desc % dev_info.rx_desc_lim.nb_align != 0) {
> > +
>
> Preferred indentation style is to line up the conditional.
> if (nb_rx_desc > dev_info.rx_desc_lim.nb_max ||
> nb_rx_desc < dev_info.rx_desc_lim.nb_min ||
> nb_rx_desc % dev_info.rx_desc_lim.nb_align != 0) {
As I remember within DPDK we use an extra tab as preferred indentation style for several years.
Why it suddenly changed now?
Konstantin
next prev parent reply other threads:[~2015-10-14 18:44 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 19:54 [dpdk-dev] [PATCHv5 0/8] " Konstantin Ananyev
2015-10-01 19:54 ` [dpdk-dev] [PATCHv5 1/8] " Konstantin Ananyev
2015-10-14 11:39 ` [dpdk-dev] [dpdk-dev, PATCHv5, " Amine Kherbouche
2015-10-14 11:49 ` Ananyev, Konstantin
2015-10-14 12:21 ` Amine Kherbouche
2015-10-14 12:42 ` Ananyev, Konstantin
2015-10-14 12:47 ` Amine Kherbouche
2015-10-14 12:48 ` Ananyev, Konstantin
2015-10-20 7:53 ` Qiu, Michael
2015-10-20 8:09 ` Vincent JARDIN
2015-10-20 8:32 ` Qiu, Michael
2015-10-14 12:44 ` [dpdk-dev] [PATCHv5 " Remy Horton
2015-10-14 16:09 ` Stephen Hemminger
2015-10-14 18:44 ` Ananyev, Konstantin [this message]
2015-10-16 13:16 ` Bruce Richardson
2015-10-19 22:06 ` [dpdk-dev] [dpdk-dev,PATCHv6 0/6] Enhance queue information API Amine Kherbouche
2015-10-19 22:06 ` [dpdk-dev] [dpdk-dev, PATCHv6 1/6] ethdev: enhance rte_eth_(tx|rx)q_info struct Amine Kherbouche
2015-10-19 22:44 ` Stephen Hemminger
2015-10-20 9:52 ` Ananyev, Konstantin
2015-10-20 14:55 ` Amine Kherbouche
2015-10-20 9:36 ` Ananyev, Konstantin
2015-10-20 15:16 ` Thomas Monjalon
2015-10-19 22:06 ` [dpdk-dev] [dpdk-dev, PATCHv6 2/6] testpmd: enhance the command to display RX/TX queue information Amine Kherbouche
2015-10-19 22:06 ` [dpdk-dev] [dpdk-dev, PATCHv6 3/6] virtio: add support for eth_(rxq|txq)_info_get Amine Kherbouche
2015-10-20 7:31 ` Tan, Jianfeng
2015-10-19 22:06 ` [dpdk-dev] [dpdk-dev, PATCHv6 4/6] e1000: enhance eth_(rxq|txq)_info_get to retrieve more queue information Amine Kherbouche
2015-10-19 22:06 ` [dpdk-dev] [dpdk-dev, PATCHv6 5/6] i40e: " Amine Kherbouche
2015-10-19 22:43 ` Stephen Hemminger
2015-10-19 22:06 ` [dpdk-dev] [dpdk-dev, PATCHv6 6/6] ixgbe: " Amine Kherbouche
2015-10-01 19:54 ` [dpdk-dev] [PATCHv5 2/8] i40e: add support for eth_(rxq|txq)_info_get and (rx|tx)_desc_lim Konstantin Ananyev
2015-10-14 12:46 ` Remy Horton
2015-10-01 19:54 ` [dpdk-dev] [PATCHv5 3/8] ixgbe: " Konstantin Ananyev
2015-10-14 12:47 ` Remy Horton
2015-10-01 19:54 ` [dpdk-dev] [PATCHv5 4/8] e1000: " Konstantin Ananyev
2015-10-14 12:48 ` Remy Horton
2015-10-01 19:54 ` [dpdk-dev] [PATCHv5 5/8] fm10k: add HW specific desc_lim data into dev_info Konstantin Ananyev
2015-10-14 12:48 ` Remy Horton
2015-10-01 19:54 ` [dpdk-dev] [PATCHv5 6/8] cxgbe: " Konstantin Ananyev
2015-10-14 12:49 ` Remy Horton
2015-10-01 19:54 ` [dpdk-dev] [PATCHv5 7/8] vmxnet3: " Konstantin Ananyev
2015-10-14 12:49 ` Remy Horton
2015-10-01 19:54 ` [dpdk-dev] [PATCHv5 8/8] testpmd: add new command to display RX/TX queue information Konstantin Ananyev
2015-10-14 12:49 ` Remy Horton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB97725836AAFAC3@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).