From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 603635A5E
 for <dev@dpdk.org>; Tue, 20 Oct 2015 11:36:42 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga101.fm.intel.com with ESMTP; 20 Oct 2015 02:36:40 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,706,1437462000"; d="scan'208";a="831078683"
Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31])
 by fmsmga002.fm.intel.com with ESMTP; 20 Oct 2015 02:36:39 -0700
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.75]) by
 IRSMSX106.ger.corp.intel.com ([169.254.8.229]) with mapi id 14.03.0248.002;
 Tue, 20 Oct 2015 10:36:37 +0100
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Amine Kherbouche <amine.kherbouche@6wind.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Thread-Topic: [dpdk-dev,PATCHv6 1/6] ethdev: enhance rte_eth_(tx|rx)q_info
 struct
Thread-Index: AQHRCrp7oiBg6mAVIUqVY/ioz5wXmp50FP8g
Date: Tue, 20 Oct 2015 09:36:37 +0000
Message-ID: <2601191342CEEE43887BDE71AB97725836AB2B07@irsmsx105.ger.corp.intel.com>
References: <1443729293-20753-2-git-send-email-konstantin.ananyev@intel.com>
 <1445292384-19815-1-git-send-email-amine.kherbouche@6wind.com>
 <1445292384-19815-2-git-send-email-amine.kherbouche@6wind.com>
In-Reply-To: <1445292384-19815-2-git-send-email-amine.kherbouche@6wind.com>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [dpdk-dev,
 PATCHv6 1/6] ethdev: enhance rte_eth_(tx|rx)q_info struct
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Oct 2015 09:36:43 -0000

Hi Amine,

> -----Original Message-----
> From: Amine Kherbouche [mailto:amine.kherbouche@6wind.com]
> Sent: Monday, October 19, 2015 11:06 PM
> To: dev@dpdk.org
> Cc: amine.kherbouche@6wind.com; vincent.jardin@6wind.com; Ananyev, Konsta=
ntin
> Subject: [dpdk-dev,PATCHv6 1/6] ethdev: enhance rte_eth_(tx|rx)q_info str=
uct
>=20
> Add 2 fields in struct rte_eth_(tx|rx)q_info :
> - used_desc : for used queue descriptors
> - free_desc : for free queue descriptors
> for ability to query more information from queues.

As I can see your patch series should be applied on top of mine:
[PATCHv5 0/8] ethdev: add new API to retrieve RX/TX queue information
Which is not yet in the dpdk.org mainline.
I believe that is ok, but then you shouldn't replace previous version with =
the patch (v5)
with new one, but create a new patch for your changes and clearly state tha=
t dependency.

Konstantin

>=20
> Signed-off-by: Amine Kherbouche <amine.kherbouche@6wind.com>
> ---
>  lib/librte_ether/rte_ethdev.h |    4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.=
h
> index 4d7b6f2..5fc86a0 100644
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -874,6 +874,8 @@ struct rte_eth_rxq_info {
>  	struct rte_eth_rxconf conf; /**< queue config parameters. */
>  	uint8_t scattered_rx;       /**< scattered packets RX supported. */
>  	uint16_t nb_desc;           /**< configured number of RXDs. */
> +	uint16_t used_desc;         /**< number of used descriptors */
> +	uint16_t free_desc;         /**< number of free descriptors */
>  } __rte_cache_aligned;
>=20
>  /**
> @@ -883,6 +885,8 @@ struct rte_eth_rxq_info {
>  struct rte_eth_txq_info {
>  	struct rte_eth_txconf conf; /**< queue config parameters. */
>  	uint16_t nb_desc;           /**< configured number of TXDs. */
> +	uint16_t used_desc;         /**< number of used descriptors */
> +	uint16_t free_desc;         /**< number of free descriptors */
>  } __rte_cache_aligned;
>=20
>  struct rte_eth_dev;
> --
> 1.7.10.4